Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264Ab2KTMR4 (ORCPT ); Tue, 20 Nov 2012 07:17:56 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:52390 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868Ab2KTMRz (ORCPT ); Tue, 20 Nov 2012 07:17:55 -0500 Date: Tue, 20 Nov 2012 13:17:47 +0100 From: Robert Richter To: Will Deacon Cc: Maynard Johnson , "jgq516@gmail.com" , "linux@arm.linux.org.uk" , "oprofile-list@lists.sf.net" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/1] ARM: oprofile: add A5/A7/A15 entries in op_perf_name Message-ID: <20121120121747.GJ2504@rric.localhost> References: <1351853016-4476-1-git-send-email-jgq516@gmail.com> <20121105113102.GF3351@mudshark.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121105113102.GF3351@mudshark.cambridge.arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 39 Will, On 05.11.12 11:31:03, Will Deacon wrote: > > diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c > > index 99c63d4b..ec10db1 100644 > > --- a/arch/arm/oprofile/common.c > > +++ b/arch/arm/oprofile/common.c > > @@ -37,8 +37,11 @@ static struct op_perf_name { > > { "xscale1", "arm/xscale2" }, > > { "v6", "arm/armv6" }, > > { "v6mpcore", "arm/mpcore" }, > > + { "ARMv7 Cortex-A5", "arm/armv7-ca5" }, > > + { "ARMv7 Cortex-A7", "arm/armv7-ca7" }, > > { "ARMv7 Cortex-A8", "arm/armv7" }, > > { "ARMv7 Cortex-A9", "arm/armv7-ca9" }, > > + { "ARMv7 Cortex-A15", "arm/armv7-ca15" }, > > }; > I'd rather not go down this route now that we have the operf tool as part of > oprofile, which can use the perf syscall directly and doesn't need this > string translation. since this is just an update of cpu detection I would be willing to include this into kernel code anyway. We could further move the cpu detection to userspace if perf_event exists. We let the kernel enable oprofile with cpu_type="unknown". User space then could either bind mount the file (user could do this manually) or we implement to write to cpu_type. Doing so oprofile could use in-kernel perf_events if it exists always as fallback. Any thoughts? -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/