Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960Ab2KTM53 (ORCPT ); Tue, 20 Nov 2012 07:57:29 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:50210 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883Ab2KTM52 (ORCPT ); Tue, 20 Nov 2012 07:57:28 -0500 MIME-Version: 1.0 In-Reply-To: References: <1353411953-27423-1-git-send-email-linus.walleij@stericsson.com> Date: Tue, 20 Nov 2012 13:57:27 +0100 Message-ID: Subject: Re: [PATCH] gpiolib: let gpiochip_add_pin_range() specify offset From: Linus Walleij To: Viresh Kumar Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shiraz Hashim , Stephen Warren , Anmar Oueja , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 35 On Tue, Nov 20, 2012 at 1:55 PM, Viresh Kumar wrote: > On 20 November 2012 17:15, Linus Walleij wrote: >> From: Linus Walleij >> >> Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76 >> it is not always enough to specify all the pins of a gpio_chip >> from offset zero to be added to a pin map range, since the >> mapping from GPIO to pin controller may not be linear at all, >> but need to be broken into a few consecutive sub-ranges or >> 1-pin entries for complicated cases. The ranges may also be >> sparse. >> >> This alters the signature of the function to accept offsets >> into both the GPIO-chip local pinspace and the pin controller >> local pinspace. >> >> Signed-off-by: Linus Walleij > > Reviewed-by: Viresh Kumar > > Aren't there any users of this routine? No so I'm trying to use it right now and have to fix it up :-) I just only got Shiraz to create it to handle non-DT devices... Will spin a V2 by the way.. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/