Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725Ab2KTQD0 (ORCPT ); Tue, 20 Nov 2012 11:03:26 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:47112 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634Ab2KTQDZ (ORCPT ); Tue, 20 Nov 2012 11:03:25 -0500 Message-ID: <50ABA9B7.7020702@gmail.com> Date: Wed, 21 Nov 2012 00:03:03 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: maciej.rutecki@gmail.com CC: Andrew Morton , Wen Congyang , David Rientjes , Jiang Liu , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFT PATCH v1 0/5] fix up inaccurate zone->present_pages References: <20121115112454.e582a033.akpm@linux-foundation.org> <1353254850-27336-1-git-send-email-jiang.liu@huawei.com> <201211192236.32152.maciej.rutecki@gmail.com> In-Reply-To: <201211192236.32152.maciej.rutecki@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2323 Lines: 58 Thanks, Maciej! On 11/20/2012 05:36 AM, Maciej Rutecki wrote: > On niedziela, 18 listopada 2012 o 17:07:25 Jiang Liu wrote: >> The commit 7f1290f2f2a4 ("mm: fix-up zone present pages") tries to >> resolve an issue caused by inaccurate zone->present_pages, but that >> fix is incomplete and causes regresions with HIGHMEM. And it has been >> reverted by commit >> 5576646 revert "mm: fix-up zone present pages" >> >> This is a following-up patchset for the issue above. It introduces a >> new field named "managed_pages" to struct zone, which counts pages >> managed by the buddy system from the zone. And zone->present_pages >> is used to count pages existing in the zone, which is >> spanned_pages - absent_pages. >> >> But that way, zone->present_pages will be kept in consistence with >> pgdat->node_present_pages, which is sum of zone->present_pages. >> >> This patchset has only been tested on x86_64 with nobootmem.c. So need >> help to test this patchset on machines: >> 1) use bootmem.c >> 2) have highmem >> >> This patchset applies to "f4a75d2e Linux 3.7-rc6" from >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> >> Any comments and helps are welcomed! >> >> Jiang Liu (5): >> mm: introduce new field "managed_pages" to struct zone >> mm: replace zone->present_pages with zone->managed_pages if >> appreciated >> mm: set zone->present_pages to number of existing pages in the zone >> mm: provide more accurate estimation of pages occupied by memmap >> mm: increase totalram_pages when free pages allocated by bootmem >> allocator >> >> include/linux/mmzone.h | 1 + >> mm/bootmem.c | 14 ++++++++ >> mm/memory_hotplug.c | 6 ++++ >> mm/mempolicy.c | 2 +- >> mm/nobootmem.c | 15 ++++++++ >> mm/page_alloc.c | 89 >> +++++++++++++++++++++++++++++++----------------- mm/vmscan.c | >> 16 ++++----- >> mm/vmstat.c | 8 +++-- >> 8 files changed, 108 insertions(+), 43 deletions(-) > Tested in 32 bit linux with HIGHMEM. Seems be OK. > > Regards > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/