Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469Ab2KTQJk (ORCPT ); Tue, 20 Nov 2012 11:09:40 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:41054 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753405Ab2KTQJi (ORCPT ); Tue, 20 Nov 2012 11:09:38 -0500 Date: Tue, 20 Nov 2012 11:09:38 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: harvey yang cc: Greg Kroah-Hartman , , Subject: Re: [RFC] usb: add 'usb_get_intf()' call into the probe methods of drivers for usb interfaces. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 24 On Mon, 19 Nov 2012, harvey yang wrote: > Hi, all > I checked many usb drivers in the mainline kernel which do not record > this reference in their probe methods. But according to the documents > about this function, we shoud record this reference in our probe > methods, just as the call to 'usb_get_dev()' to reference a usb > device. Are these usb drivers right or we need to fix them? The drivers are right; they do not need to be fixed. The reason is because the drivers will be unbound automatically when the device or interface is unregistered. The only reason for a driver to take a reference would be if it wanted to continue using the device after it was unbound. But drivers aren't supposed to do that. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/