Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975Ab2KTU1L (ORCPT ); Tue, 20 Nov 2012 15:27:11 -0500 Received: from mms3.broadcom.com ([216.31.210.19]:2663 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668Ab2KTU1K (ORCPT ); Tue, 20 Nov 2012 15:27:10 -0500 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Message-ID: <1353443183.10779.12.camel@lb-tlvb-eilong.il.broadcom.com> Subject: Re: [PATCH v2] checkpatch: add double empty line check From: "Eilon Greenstein" Reply-to: eilong@broadcom.com To: "Andy Whitcroft" cc: "Joe Perches" , "David Rientjes" , "linux-kernel@vger.kernel.org" , netdev Date: Tue, 20 Nov 2012 22:26:23 +0200 In-Reply-To: <20121120201142.GI17797@dm> References: <20121120115239.GA7955@dm> <1353421624.6559.9.camel@lb-tlvb-eilong.il.broadcom.com> <20121120144329.GE7955@dm> <1353424027.6559.15.camel@lb-tlvb-eilong.il.broadcom.com> <20121120154443.GK7955@dm> <1353427570.6559.21.camel@lb-tlvb-eilong.il.broadcom.com> <20121120161417.GA17797@dm> <20121120163607.GB17797@dm> <1353438635.10779.10.camel@lb-tlvb-eilong.il.broadcom.com> <20121120193249.GH17797@dm> <20121120201142.GI17797@dm> Organization: Broadcom X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-WSS-ID: 7CB539123P86553480-03-01 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 28 On Tue, 2012-11-20 at 20:11 +0000, Andy Whitcroft wrote: > > > > Actually the version I sent should indeed cope with the deleted lines > > regardless of order. It was cirtainly intended to. > > ... and I think I thought of a couple more corner cases neither solution > will find. So I am going to go away and make up a proper set of tests > for this apparently simple change. As it is really annoying when it > false positives. I will post against when I have something which works. > Thanks Andy! I will assist in testing it on all the scenarios I have created once you post it. I appreciate you taking the time to look into adding a test for this issue. Thanks, Eilon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/