Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753260Ab2KUBv0 (ORCPT ); Tue, 20 Nov 2012 20:51:26 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:58873 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219Ab2KUBvZ (ORCPT ); Tue, 20 Nov 2012 20:51:25 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 21 Nov 2012 09:51:24 +0800 Message-ID: Subject: Re: [RFC] usb: add 'usb_get_intf()' call into the probe methods of drivers for usb interfaces. From: harvey yang To: Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 30 Thanks for your comments :) Harvey On Wed, Nov 21, 2012 at 12:09 AM, Alan Stern wrote: > On Mon, 19 Nov 2012, harvey yang wrote: > >> Hi, all >> I checked many usb drivers in the mainline kernel which do not record >> this reference in their probe methods. But according to the documents >> about this function, we shoud record this reference in our probe >> methods, just as the call to 'usb_get_dev()' to reference a usb >> device. Are these usb drivers right or we need to fix them? > > The drivers are right; they do not need to be fixed. The reason is > because the drivers will be unbound automatically when the device or > interface is unregistered. > > The only reason for a driver to take a reference would be if it wanted > to continue using the device after it was unbound. But drivers aren't > supposed to do that. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/