Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754210Ab2KUCsC (ORCPT ); Tue, 20 Nov 2012 21:48:02 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:39931 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272Ab2KUCsB (ORCPT ); Tue, 20 Nov 2012 21:48:01 -0500 Date: Tue, 20 Nov 2012 21:47:53 -0500 From: Konrad Rzeszutek Wilk To: Dan Magenheimer Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org Subject: Re: [PATCH] xen: tmem: selfballooning should be enabled when xen tmem is enabled Message-ID: <20121121024753.GB11912@konrad-lan.dumpdata.com> References: <748aba10-531a-4ad5-bad3-7af0f86c0489@default> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <748aba10-531a-4ad5-bad3-7af0f86c0489@default> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2066 Lines: 48 On Tue, Nov 20, 2012 at 02:42:18PM -0800, Dan Magenheimer wrote: > Konrad: Any chance this can get in for the upcoming window? > (Or is it enough of a bug fix that it can go in at an -rcN?) Lets do it in the next merge window. About now I am comfortable only with regression fixes. > > It was just pointed out to me that some kernels have > cleancache and frontswap and xen_tmem enabled but NOT > xen_selfballooning! While this configuration should be > possible, nearly all kernels that have CONFIG_XEN_TMEM=y should > also have CONFIG_XEN_SELFBALLOONING=y, since Transcendent > Memory (tmem) for Xen has very limited value without > selfballooning. > > This is probably a result of a Kconfig mistake fixed I think > by the patch below. Note that the year-old Oracle UEK2 kernel > distro has both CONFIG_XEN_TMEM and CONFIG_XEN_SELFBALLOONING > enabled, as does a Fedora 17 kernel update (3.6.6-1.fc17), so > the combination should be well tested. Also, Xen tmem (and thus > selfballooning) are currently only enabled when a kernel boot > parameter is supplied so there is no runtime impact without > that boot parameter. > > Signed-off-by: Dan Magenheimer > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index d4dffcd..b5f02f3 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -10,9 +10,9 @@ config XEN_BALLOON > return unneeded memory to the system. > > config XEN_SELFBALLOONING > - bool "Dynamically self-balloon kernel memory to target" > - depends on XEN && XEN_BALLOON && CLEANCACHE && SWAP && XEN_TMEM > - default n > + bool > + depends on XEN_BALLOON && SWAP > + default y if XEN_TMEM > help > Self-ballooning dynamically balloons available kernel memory driven > by the current usage of anonymous memory ("committed AS") and -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/