Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285Ab2KUHjl (ORCPT ); Wed, 21 Nov 2012 02:39:41 -0500 Received: from mail-vb0-f46.google.com ([209.85.212.46]:57663 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab2KUHjk (ORCPT ); Wed, 21 Nov 2012 02:39:40 -0500 MIME-Version: 1.0 In-Reply-To: <50ABBCD7.3000006@wwwdotorg.org> References: <1353411953-27423-1-git-send-email-linus.walleij@stericsson.com> <50ABBCD7.3000006@wwwdotorg.org> Date: Wed, 21 Nov 2012 08:39:39 +0100 Message-ID: Subject: Re: [PATCH] gpiolib: let gpiochip_add_pin_range() specify offset From: Linus Walleij To: Stephen Warren Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shiraz Hashim , Viresh Kumar , Stephen Warren , Anmar Oueja , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 34 On Tue, Nov 20, 2012 at 6:24 PM, Stephen Warren wrote: > On 11/20/2012 04:45 AM, Linus Walleij wrote: >> From: Linus Walleij >> >> Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76 >> it is not always enough to specify all the pins of a gpio_chip >> from offset zero to be added to a pin map range, since the >> mapping from GPIO to pin controller may not be linear at all, >> but need to be broken into a few consecutive sub-ranges or >> 1-pin entries for complicated cases. The ranges may also be >> sparse. >> >> This alters the signature of the function to accept offsets >> into both the GPIO-chip local pinspace and the pin controller >> local pinspace. > > Reviewed-by: Stephen Warren > > Although perhaps rename the new "offset" parameter to "gpio_base" or > "gpio_offset", just like the existing "pin_base" rather than > pin/base/offset? OK I'll rename it... I've also made a fat notice that this isn't currently covered by the OF GPIO range bindings as a follow-on patch. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/