Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980Ab2KUMwY (ORCPT ); Wed, 21 Nov 2012 07:52:24 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:52210 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897Ab2KUMwQ (ORCPT ); Wed, 21 Nov 2012 07:52:16 -0500 From: Stephane Eranian To: linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com, Namhyung Kim Subject: [PATCH v3 18/19] perf tools: Ignore ABS symbols when loading data maps Date: Wed, 21 Nov 2012 13:49:44 +0100 Message-Id: <1353502185-26521-19-git-send-email-eranian@google.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1353502185-26521-1-git-send-email-eranian@google.com> References: <1353502185-26521-1-git-send-email-eranian@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1153 Lines: 36 From: Namhyung Kim When loading symbols in a data mapping, ABS symbols (which has a value of SHN_ABS in its st_shndx) failed at elf_getscn(). And it marks the loading as a failure so already loaded symbols cannot be fixed up. I'm not sure what should be done. Just ignore them for now. :) Cc: Stephane Eranian Signed-off-by: Namhyung Kim --- tools/perf/util/symbol-elf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index db0cc92..00cf128 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -719,6 +719,9 @@ int dso__load_sym(struct dso *dso, struct map *map, used_opd = true; } + if (sym.st_shndx == SHN_ABS) + continue; + sec = elf_getscn(runtime_ss->elf, sym.st_shndx); if (!sec) goto out_elf_end; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/