Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755162Ab2KUP3L (ORCPT ); Wed, 21 Nov 2012 10:29:11 -0500 Received: from mail-qc0-f174.google.com ([209.85.216.174]:64874 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754921Ab2KUP3J (ORCPT ); Wed, 21 Nov 2012 10:29:09 -0500 MIME-Version: 1.0 In-Reply-To: <20121121151604.GA21983@kroah.com> References: <1353475147-28308-1-git-send-email-sachin.kamat@linaro.org> <20121121144624.GA21766@kroah.com> <20121121151604.GA21983@kroah.com> Date: Wed, 21 Nov 2012 20:59:08 +0530 Message-ID: Subject: Re: [PATCH 1/1] tty: vt: Remove redundant null check before kfree. From: Sachin Kamat To: Greg KH Cc: linux-kernel@vger.kernel.org, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2087 Lines: 60 On 21 November 2012 20:46, Greg KH wrote: > On Wed, Nov 21, 2012 at 08:21:40PM +0530, Sachin Kamat wrote: >> On 21 November 2012 20:16, Greg KH wrote: >> > On Wed, Nov 21, 2012 at 10:49:07AM +0530, Sachin Kamat wrote: >> >> kfree on a NULL pointer is a no-op. >> >> >> >> Signed-off-by: Sachin Kamat >> >> --- >> >> drivers/tty/vt/consolemap.c | 6 ++---- >> >> 1 files changed, 2 insertions(+), 4 deletions(-) >> >> >> >> diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c >> >> index 2aaa0c2..248381b 100644 >> >> --- a/drivers/tty/vt/consolemap.c >> >> +++ b/drivers/tty/vt/consolemap.c >> >> @@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p) >> >> kfree(p->inverse_translations[i]); >> >> p->inverse_translations[i] = NULL; >> >> } >> >> - if (p->inverse_trans_unicode) { >> >> - kfree(p->inverse_trans_unicode); >> >> - p->inverse_trans_unicode = NULL; >> >> - } >> >> + kfree(p->inverse_trans_unicode); >> >> + p->inverse_trans_unicode = NULL; >> > >> > kfree with NULL is a no-op, but the line after that just caused a kernel >> > crash if it was NULL, so I can't accept this type of thing. >> > >> > Please be more careful. >> >> My mistake. Apologies for the same. >> >> Do we need to assign the pointer to NULL after freeing? > > It depends if it is checked later on, is it? I will re-send this patch after deleting the assignment? > >> > What's with the patches@linaro.org email address? What is that for? >> That is a logging mechanism (done by patchwork) for all patches sent >> by Linaro engineers. > > So you can track it internally? Why? Yes. For tracking the status. > > greg k-h -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/