Date: Wed, 21 Nov 2012 13:10:18 -0800 (PST)
From: Andy King <acking@vmware.com>
To: Joe Perches <joe@perches.com>
Cc: pv-drivers@vmware.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        George Zhang <georgezhang@vmware.com>
Message-ID: <904751617.29421555.1353532218495.JavaMail.root@vmware.com>
In-Reply-To: <1353531886.24807.43.camel@joe-AO722>
Subject: Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 960
Lines: 34

Hi Joe,

> Just some trivial notes.

Thanks for taking a look!

> > +		pr_warn("Failed to allocate memory for VMCI context.\n");
> 
> OOM logging messages aren't necessary as alloc failures
> are already logged with a stack trace.

Noted, we'll remove all such occurrences.

> Maybe just use
> 	struct vmci_event_msg e_msg;
> 	struct vmci_event_payld_ctx ev_payload;
> and change the addressing or use a cast as appropriate?

It does seem inelegant, we'll take a look.

> You also have some inconsistency in whether or not your
> logging messages use a terminating period.  I suggest
> you just delete all the periods.
> 	s/\.\\n"/\\n"/g

Gah, that's ugly.  We'll remove all of them as you suggest.

Thanks!
- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/