Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965223Ab2KVT35 (ORCPT ); Thu, 22 Nov 2012 14:29:57 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:64301 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965124Ab2KVT3y (ORCPT ); Thu, 22 Nov 2012 14:29:54 -0500 MIME-Version: 1.0 In-Reply-To: <20121121204324.21126.99677@nucleus> References: <1353403339-11679-1-git-send-email-dmitry.torokhov@gmail.com> <1353403339-11679-2-git-send-email-dmitry.torokhov@gmail.com> <20121121204324.21126.99677@nucleus> Date: Thu, 22 Nov 2012 09:04:18 +0530 Message-ID: Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() From: Viresh Kumar To: Mike Turquette Cc: Dmitry Torokhov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 27 On 22 November 2012 02:13, Mike Turquette wrote: > HAVE_CLK logically wraps HAVE_CLK_PREPARE. There is no point in > selecting HAVE_CLK_PREPARE without HAVE_CLK. > > Looking through the code I see that this used to be the case. Commit > 93abe8e "clk: add non CONFIG_HAVE_CLK routines" moved the > clk_(un)prepare declarations outside of #ifdef CONFIG_HAVE_CLK. That > commit was authored by you. Can you elaborate on why that aspect of the > patch was needed? Haha... Caught red handed :( Before this commit, nothing was enclosed within CONFIG_HAVE_CLK and this patch only introduced it. I am not really sure, why i kept prepare/unprepare out of it though :( Maybe because some platform at that time is using it directly, without CONFIG_HAVE_CLK. Not sure. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/