Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756312Ab2KVUmI (ORCPT ); Thu, 22 Nov 2012 15:42:08 -0500 Received: from mail-vc0-f174.google.com ([209.85.220.174]:45127 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756270Ab2KVUmF (ORCPT ); Thu, 22 Nov 2012 15:42:05 -0500 MIME-Version: 1.0 Date: Thu, 22 Nov 2012 14:52:35 +0530 Message-ID: Subject: [PATCH 3.6.6 0/3] i82975x_edac: fatal bug fixed From: Arvind R To: linux-edac@vger.kernel.org Cc: LKML , Mauro Carvalho Chehab Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 38 Subject: [PATCH 3.6.6 0/3] i82975x_edac: fatal bug fixed This patchset fixes fatal crash caused by i82975x_edac driver. It consists of 3 parts: 1. Move the debug code to conform to the edac_core standard instead of using hardcoded ifdefs. Also add some more dram info outputs in the debug output. 2. Cleanup the long lines and other format errors found. Use defines for numeric constants used repeatedly in code. 3. Fix the crash caused by wrong memory_layer initialisation and dimm_label initialisation. Almost total, but cleaner rewrite of csrow_info initialisation. And a terser error reporting function. The patch has been applied to linux-3.6.6 and tested on on Asus P5WDG2 WS Pro mobo with 7 memory configurations, 3 symmetric and 4 assymmetric: Symmetric: 1. 2 ECC DIMMS, one on slot A1 and other on slot B1 2. 2 ECC DIMMS, one on slot A2 and other on slot B2 3. 4 ECC DIMMS, mobo fully populated. Assymmetric: 1. 1 ECC DIMM on A1 2. 1 ECC DIMM on B1 3. 2 ECC DIMMS on A1 and B2 4. 3 ECC DIMMS on A1, B2, B2 Size, label values in /sys/devices/system/edac/mc/mc0 found consistent. Tested-by: Arvind R. Signed-off-by: Arvind R. --- drivers/edac/i82975x_edac.c | 361 +++++++++++++++++----------------- 1 file changed, 185 insertions(+), 176 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/