Date: Thu, 22 Nov 2012 21:59:44 +0100
From: Thierry Reding <thierry.reding@avionic-design.de>
To: "Philip, Avinash" <avinashphilip@ti.com>
Cc: paul@pwsan.com, tony@atomide.com, linux@arm.linux.org.uk, b-cousson@ti.com,
        hvaibhav@ti.com, anilkumar@ti.com, linux-kernel@vger.kernel.org,
        devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        nsekhar@ti.com, gururaja.hebbar@ti.com, vaibhav.bedia@ti.com
Subject: Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support
Message-ID: <20121122205944.GC16716@avionic-0098.adnet.avionic-design.de>
References: <1353503469-18634-1-git-send-email-avinashphilip@ti.com>
 <1353503469-18634-6-git-send-email-avinashphilip@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J"
Content-Disposition: inline
In-Reply-To: <1353503469-18634-6-git-send-email-avinashphilip@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1562
Lines: 42


--Izn7cH1Com+I3R9J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote:
[...]
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev, "failed to configure pins from driver\n");

I think we already discussed this, but shouldn't this be a fatal error?

Thierry

--Izn7cH1Com+I3R9J
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJQrpJAAAoJEN0jrNd/PrOhWpwP/iUHHBVkmCk5Chr1iJN2CCjy
hr2gF3YlBQpHpyyvH9+rqtkRzJ0+7iPvq8gaM3pQoW67lgrD5H7nHxqfCqdxghV2
8ARiatAsfiWHAhHi/O9uNCkJ+NZv9YyPaPsrkJvaSie+O14HEAM5kiHtDOpFDkkd
STfXFUHIgMtajNMo4MnjON8FTr7dLv4/RmXVymeUskopkpYoD/hvpqlg1ivEz0M6
UKbbPZ6Z6iiLp5wwGYBEN8dhHA7uHqjFmRfu4dDdD8tKwMLxCVN6EA539VawWmeU
x2gjBbE2Vi5REBt8G+gDkJqCcSB46Xqzg7beZSb7C96bPuxFcI1cWZKzGnjCeyfM
pACqZFHbci8+9hqWYkhAJ3PnCfXn9asR5UMfiwVUxRG7v6LaHPzh4dYpNeW2bDGB
E2RCC2AeFKJ5SqsmM/YOQROHS88RDAFBaXYjly4kPj7Z9dNI+pgoPMVJg3B+tpMI
Ob9NNyYXP+NNOedGrBYdNhnj8Z+51aYMtKAG/KWYyga4U+1JkHEmIQ2BpAfemh/u
WMNqWVSFA/y8hf2AT3PH9Vq0GgfpqfOrOIKZLnwdIAeIl9uEDwp0phDMGkB6Nnwg
ckGRHEo3oQfMzACNUjuXO2vX0TOIig8+rFrThqotrGP+z3wTZNpjevkC1JUImJp4
9veop7y+AI0mSrvAqmru
=7YdN
-----END PGP SIGNATURE-----

--Izn7cH1Com+I3R9J--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/