Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758516Ab2KVWcd (ORCPT ); Thu, 22 Nov 2012 17:32:33 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:49161 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758452Ab2KVWbr (ORCPT ); Thu, 22 Nov 2012 17:31:47 -0500 Date: Thu, 22 Nov 2012 09:30:33 +0000 From: Russell King - ARM Linux To: Dmitry Torokhov Cc: Mike Turquette , Viresh Kumar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() Message-ID: <20121122093033.GA5764@n2100.arm.linux.org.uk> References: <1353403339-11679-1-git-send-email-dmitry.torokhov@gmail.com> <1353403339-11679-2-git-send-email-dmitry.torokhov@gmail.com> <20121121204324.21126.99677@nucleus> <20121121205424.GA25470@core.coreip.homeip.net> <20121121223859.GQ3290@n2100.arm.linux.org.uk> <20121122021750.GD25470@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121122021750.GD25470@core.coreip.homeip.net> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 28 On Wed, Nov 21, 2012 at 06:17:50PM -0800, Dmitry Torokhov wrote: > > You've checked non-ARM architectures too? > > Yes: > > [dtor@dtor-d630 linux-next]$ grep -r HAVE_CLK_PREPARE . > ./arch/arm/Kconfig: select HAVE_CLK_PREPARE > Binary file ./.git/objects/pack/pack-7dad5ee164f601f1327dc78648fa317772c2d872.pack matches > ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE > ./include/linux/clk.h:#ifdef CONFIG_HAVE_CLK_PREPARE > ./drivers/clk/Kconfig:config HAVE_CLK_PREPARE > ./drivers/clk/Kconfig: select HAVE_CLK_PREPARE Err, no you haven't, not with that grep. What you've found are the places which enable this, and say "yes, I have clk_prepare". What HAVE_CLK_PREPARE is about though is providing a transition path between drivers using clk_prepare() to platforms which _don't_ have a clk_prepare() implementation - and when it's unset, it provides a default implementation. So, finding all those places where the symbol exists is the exact opposite of what you need to be doing. You need to find those platforms which have CLK support, but which don't have HAVE_CLK_PREPARE selected. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/