Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932886Ab2KWH14 (ORCPT ); Fri, 23 Nov 2012 02:27:56 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:39003 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932513Ab2KWH1z (ORCPT ); Fri, 23 Nov 2012 02:27:55 -0500 MIME-Version: 1.0 In-Reply-To: <20121123071931.GB12631@core.coreip.homeip.net> References: <1353403339-11679-1-git-send-email-dmitry.torokhov@gmail.com> <1353403339-11679-2-git-send-email-dmitry.torokhov@gmail.com> <20121121204324.21126.99677@nucleus> <20121121205424.GA25470@core.coreip.homeip.net> <20121121223859.GQ3290@n2100.arm.linux.org.uk> <20121122021750.GD25470@core.coreip.homeip.net> <20121122093033.GA5764@n2100.arm.linux.org.uk> <20121123071931.GB12631@core.coreip.homeip.net> Date: Fri, 23 Nov 2012 12:57:54 +0530 Message-ID: Subject: Re: [PATCH 1/3] CLK: uninline clk_prepare() and clk_unprepare() From: Viresh Kumar To: Dmitry Torokhov Cc: Russell King - ARM Linux , Mike Turquette , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 24 On 23 November 2012 12:49, Dmitry Torokhov wrote: > Ahh, I see. Then I think my first patch was correct albeit it had bad changelog > message. If provided stubs for clk_prepare()/clk_unprepare() for > platforms that did not define HAVE_CLK and pushed the check for > HAVE_CLK_PREPARE down into drivers/clk/clk.c so __clk_prepare() would > either call platform implementation or just be an empty function. > > Am I correct or I am still missing something? I believe you are still missing it :) clk.c will only be compiled when we have COMMON_CLK and COMMON_CLK selects HAVE_CLK_PREPARE. So, using HAVE_CLK_PREPARE in clk.c is useless, as its always true. I feel, the best solution would be to simply drop patch 1 and apply others. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/