Date: Fri, 23 Nov 2012 10:41:40 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linus.walleij@linaro.org, grant.likely@secretlab.ca,
        devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        spear-devel@list.st.com, Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Message-ID: <20121123104140.GP17471@gmail.com>
References: <912d88b8906ce87cf5459cf3d5798e03bfce34c7.1353649737.git.viresh.kumar@linaro.org>
 <20121123103400.GO17471@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20121123103400.GO17471@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1450
Lines: 52

> >  static struct mfd_cell stmpe_gpio_cell = {
> >  	.name		= "stmpe-gpio",
> > +	.of_compatible	= "st,stmpe-gpio",
> 
> There's no need for any of the STMPE to have their own compatible
> string, as they are MFD devices. They are registered as platform
> devices from the MFD subsystem.

Whoops, I've written this in the wrong place. 

Sorry, for the confusion. It does need to be here.

> >  	.resources	= stmpe_gpio_resources,
> >  	.num_resources	= ARRAY_SIZE(stmpe_gpio_resources),
> >  };
> >  
> >  static struct mfd_cell stmpe_gpio_cell_noirq = {
> >  	.name		= "stmpe-gpio",
> > +	.of_compatible	= "st,stmpe-gpio",

... and here.

> > +++ b/Documentation/devicetree/bindings/gpio/gpio-stmpe.txt
> > @@ -0,0 +1,18 @@
> > +STMPE gpio
> > +----------
> > +
> > +Required properties:
> > + - compatible: "st,stmpe-gpio"

... but this is wrong.

> > +Example:
> > +	stmpe_gpio {
> > +		compatible = "st,stmpe-gpio";
> > +		st,norequest-mask = <0x20>;	//gpio 5 can't be used
> > +	};

As is the example.

So will be the the DT - if you've already written it.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/