Message-ID: <50AFEBA5.9060006@nvidia.com>
Date: Sat, 24 Nov 2012 03:03:25 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7
MIME-Version: 1.0
To: Axel Lin <axel.lin@ingics.com>
CC: Samuel Ortiz <sameo@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] mfd: rc5t583: Fix array subscript is above array
 bounds
References: <1353378896.6455.1.camel@phoenix>
In-Reply-To: <1353378896.6455.1.camel@phoenix>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1260
Lines: 32

On Tuesday 20 November 2012 08:04 AM, Axel Lin wrote:
> I got below build warning while compiling this driver.
> It's obviously RC5T583_MAX_INTERRUPT_MASK_REGS is 9 but irq_en_add array only
> has 8 elements.
>
>    CC      drivers/mfd/rc5t583-irq.o
> drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_sync_unlock':
> drivers/mfd/rc5t583-irq.c:227: warning: array subscript is above array bounds
> drivers/mfd/rc5t583-irq.c: In function 'rc5t583_irq_init':
> drivers/mfd/rc5t583-irq.c:349: warning: array subscript is above array bounds
>
> Since the number of interrupt enable registers is 8, this patch adds define for
> RC5T583_MAX_INTERRUPT_EN_REGS to fix this bug.
>
> Signed-off-by: Axel Lin<axel.lin@ingics.com>
> ---
> Hi Laxman,
>    I don't have this hardware, I'd appreciate if you can review and test this patch.
> Thank you,
> Axel

This looks good. I dont see any issue on this.
I am planning to move this to regmap-irq, probably on next release.

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/