Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049Ab2KXCjx (ORCPT ); Fri, 23 Nov 2012 21:39:53 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:46403 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752243Ab2KXCjw (ORCPT ); Fri, 23 Nov 2012 21:39:52 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX185zq5F/HKqySAkA13gW5Seid96n8Ny6Sc= Date: Fri, 23 Nov 2012 21:39:42 -0500 From: Jason Cooper To: Sebastian Hesselbarth Cc: Thomas Petazzoni , Andrew Lunn , Russell King , Linus Walleij , linux-kernel@vger.kernel.org, Gregory CLEMENT , Axel Lin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl Message-ID: <20121124023942.GO15800@titan.lakedaemon.net> References: <1353317996-20841-1-git-send-email-sebastian.hesselbarth@gmail.com> <1353317996-20841-4-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353317996-20841-4-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3202 Lines: 109 On Mon, Nov 19, 2012 at 10:39:55AM +0100, Sebastian Hesselbarth wrote: > Following the ongoing conversion of Orion SoCs to DT, make use of > gpio and pinctrl drivers through DT. The main dtsi for Dove is prepared > to allow board specific descriptors to make use of pinctrl muxing. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Linus Walleij > Cc: Sebastian Hesselbarth > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Thomas Petazzoni > Cc: Gregory CLEMENT > Cc: Axel Lin > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/Kconfig | 2 ++ > arch/arm/boot/dts/dove.dtsi | 20 +++++++++++++++++--- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index d5a28da..bb9a85d 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -539,6 +539,8 @@ config ARCH_DOVE > select CPU_V7 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > + select PINCTRL > + select PINCTRL_DOVE > select PLAT_ORION_LEGACY > select USB_ARCH_HAS_EHCI > help > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > index 8c8ab62..c457480 100644 > --- a/arch/arm/boot/dts/dove.dtsi > +++ b/arch/arm/boot/dts/dove.dtsi > @@ -4,6 +4,12 @@ > compatible = "marvell,dove"; > model = "Marvell Armada 88AP510 SoC"; > > + aliases { > + gpio0 = &gpio0; > + gpio1 = &gpio1; > + gpio2 = &gpio2; > + }; > + > soc@f1000000 { > compatible = "simple-bus"; > #address-cells = <1>; > @@ -85,7 +91,8 @@ > #gpio-cells = <2>; > gpio-controller; > reg = <0xd0400 0x20>; > - ngpio = <32>; > + ngpios = <32>; > + interrupt-controller; > interrupts = <12>, <13>, <14>, <60>; > }; > > @@ -94,7 +101,8 @@ > #gpio-cells = <2>; > gpio-controller; > reg = <0xd0420 0x20>; > - ngpio = <32>; > + ngpios = <32>; > + interrupt-controller; > interrupts = <61>; > }; > > @@ -103,7 +111,13 @@ > #gpio-cells = <2>; > gpio-controller; > reg = <0xe8400 0x0c>; > - ngpio = <8>; > + ngpios = <8>; > + }; > + > + pinctrl: pinctrl@d0200 { > + compatible = "marvell,dove-pinctrl"; > + reg = <0xd0200 0x10>; > + clocks = <&gate_clk 22>; The above line broke the dtbs build target for dove_defconfig. I have removed it. Please let me know if that is not the correct answer. This was the only occurence of 'clk' in arch/arm/boot/dts/dove* . thx, Jason. > }; > > spi0: spi@10600 { > -- > 1.7.10.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/