MIME-Version: 1.0
In-Reply-To: <20121124070337.GA8030@mail.gnudd.com>
References: <CAKohpokUHv96wutU1ZLxxnndR3wfTr3kjh3UKREtuiVV-V8+EA@mail.gmail.com>
	<1353718436-20194-1-git-send-email-ciminaghi@gnudd.com>
	<CAJe_ZhcGmeTviV8v8eCMFZTWLnOb24_kVa1TkZF=9oyc6=vA4A@mail.gmail.com>
	<20121124070337.GA8030@mail.gnudd.com>
Date: Sat, 24 Nov 2012 16:35:37 +0530
Message-ID: <CAJe_Zhck-vLQEHisE2ORbygmhA=7fcStuvOo2f4rvuCa1tAhEg@mail.gmail.com>
Subject: Re: [PATCH 1/8 v3] DMA: PL330: use prefix in reg names to build under x86
From: Jassi Brar <jaswinder.singh@linaro.org>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: ciminaghi@gnudd.com, viresh.linux@gmail.com, giancarlo.asnaghi@st.com,
        rajeev-dlh.kumar@st.com, linux@arm.linux.org.uk, nico@fluxnic.net,
        vinod.koul@intel.com, linus.walleij@linaro.org, hpa@zytor.com,
        linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, wim@iguana.be,
        mingo@redhat.com, ben-linux@fluff.org, djbw@fb.com, tglx@linutronix.de,
        cjb@laptop.org, linux-arm-kernel@lists.infradead.org,
        davidb@codeaurora.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1618
Lines: 38

On 24 November 2012 12:33, Alessandro Rubini <rubini@gnudd.com> wrote:
> My patch:
>>> This driver would not compile if ARM_AMBA is selected under x86,
>>> because "CS" and "DS" are already defined there.  But AMBA
>>> is used in the x86 world by a PCI-to-AMBA bridge, to be submitted.
>>>
>>> The patch just adds the "PL330_" prefix to all register and bit fields,
>>> so it can be built by randomconfig after ARM_AMBA appears within x86.
>
> Jassy Brar:
>> Prefixing only CS and DS should be do the job.
>> Why do we have to make every symbol noisy with PL330_ ?
>
> For internal consistency. I attacked this problem in July. This is
> what you wrote:
>
>    I fully agree with your point and IIRC I always add some prefix to
>    definitions in header files.
>    Private defines in a .c file, without redundant prefixes, sounded like
>    safe to me at the time, but perhaps I was wrong.
>
>    (references: http://lkml.org/lkml/2012/7/1/56)
>
> So I made the changes overall.  I dislike needless long patches, but
> picking symbols to work around the conflict of the day while
> introducing inconsistent naming doesn't look good to me.
>
Sorry if I gave the wrong impression. I didn't agree (and IIRC nobody
suggested) we prefix _every_ symbol in the driver now. Just CS, DS, ES
and maybe SA, DA, CC too for some consistency. IOW, only regs, not
bit-fields.

regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/