Date: Mon, 26 Nov 2012 11:30:34 +0200
From: Baruch Siach <baruch@tkos.co.il>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Andrew Lunn <andrew@lunn.ch>, Axel Lin <axel.lin@ingics.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org,
        Gregory CLEMENT <gregory.clement@free-electrons.com>,
        Russell King <linux@arm.linux.org.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pinctrl: mvebu: make pdma clock on dove mandatory
Message-ID: <20121126093033.GH12673@sapphire.tkos.co.il>
References: <1353921525-25163-1-git-send-email-sebastian.hesselbarth@gmail.com>
 <1353921634-25210-1-git-send-email-sebastian.hesselbarth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353921634-25210-1-git-send-email-sebastian.hesselbarth@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 40

Hi Sebastian,

On Mon, Nov 26, 2012 at 10:20:34AM +0100, Sebastian Hesselbarth wrote:

[...]

> diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c 
> b/drivers/pinctrl/mvebu/pinctrl-dove.c
> index 40c9c3e..90f257d 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-dove.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c
> @@ -595,8 +595,11 @@ static int __devinit dove_pinctrl_probe(struct platform_device *pdev)
>  	 * grab clk to make sure it is ticking.
>  	 */
>  	clk = devm_clk_get(&pdev->dev, NULL);
> -	if (!IS_ERR(clk))
> -		clk_prepare_enable(clk);
> +	if (IS_ERR(clk)) {
> +		dev_err(&pdev->dev, "Unable to get pdma clock");
> +		return -ENODEV;

Why not propagate the error up using PTR_RET(clk)?

baruch

> +	}
> +	clk_prepare_enable(clk);
>  
>  	return mvebu_pinctrl_probe(pdev);
>  }

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/