Date: Mon, 26 Nov 2012 17:02:30 +0530
From: Shiraz Hashim <shiraz.hashim@st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: <linus.walleij@linaro.org>, Viresh Kumar <viresh.kumar@linaro.org>,
        <grant.likely@secretlab.ca>, <devicetree-discuss@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>, <spear-devel@list.st.com>,
        Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Message-ID: <20121126113230.GT5384@localhost.localdomain>
References: <912d88b8906ce87cf5459cf3d5798e03bfce34c7.1353649737.git.viresh.kumar@linaro.org>
 <20121123103400.GO17471@gmail.com>
 <CAKohponW-Wd+Vrnj8mbdFMmJvwQgPq1jFCZRipBFoEhTknStHQ@mail.gmail.com>
 <20121123121413.GB22268@gmail.com>
 <20121123123048.GM5384@localhost.localdomain>
 <20121126112823.GI12782@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20121126112823.GI12782@gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1318
Lines: 36

On Mon, Nov 26, 2012 at 11:28:23AM +0000, Lee Jones wrote:
> On Fri, 23 Nov 2012, Shiraz Hashim wrote:
> 
> > On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > > > >> +             if (np)
> > > > >> +                     of_property_read_u32(np, "st,norequest-mask",
> > > > >> +                                     &pdata->norequest_mask);
> > > > >
> > > > > Can you explain to me what this does?
> > > > 
> > > > You mean pdata->norequest_mask?  It marks few gpios as unusable.
> > > > Because these pads might be used by other blocks of stmpe.
> > > 
> > > I'm not sure if that should be set with DT or not.
> > > 
> > > Second opinion anyone?
> > 
> > This is a board dependent parameter which just informs gpio driver
> > about pins, which must not be requested. It may happen for a stmpe
> > variant where such gpio pins are multiplexed with some other
> > function.
> > 
> > Hence it must be part of DT itself.
> 
> Doesn't pinctrl normally handle this kind of stuff?

Yes, but I think it is only for managing the SoC and its pads.

--
regards
Shiraz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/