Message-ID: <1353956163.6276.46.camel@gandalf.local.home>
Subject: Re: [PATCH 2/3] cputime: Rename thread_group_times to
 thread_group_cputime_adjusted
From: Steven Rostedt <rostedt@goodmis.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Date: Mon, 26 Nov 2012 13:56:03 -0500
In-Reply-To: <1353680484-7302-3-git-send-email-fweisbec@gmail.com>
References: <1353680484-7302-1-git-send-email-fweisbec@gmail.com>
	 <1353680484-7302-3-git-send-email-fweisbec@gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 37

On Fri, 2012-11-23 at 15:21 +0100, Frederic Weisbecker wrote:
> We have thread_group_cputime() and thread_group_times(). The naming
> doesn't provide enough information about the difference between
> these two APIs.
> 
> To lower the confusion, rename thread_group_times() to
> thread_group_cputime_adjusted(). This name better suggests that
> it's a version of thread_group_cputime() that does some stabilization
> on the raw cputime values. ie here: scale on top of CFS runtime
> stats and bound lower value for monotonicity.

But, thread_group_times() does not do any type of adjustment. It only
retrieves the cpu times:

void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t *st)
{
        struct task_cputime cputime;

        thread_group_cputime(p, &cputime);

        *ut = cputime.utime;
        *st = cputime.stime;
}


It retrieves the current times, it doesn't adjust them.

I'm thinking the current name is more accurate.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/