Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755446Ab2KZTVy (ORCPT ); Mon, 26 Nov 2012 14:21:54 -0500 Received: from casper.infradead.org ([85.118.1.10]:34225 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472Ab2KZTVw (ORCPT ); Mon, 26 Nov 2012 14:21:52 -0500 Message-ID: <50B3C13D.1050704@infradead.org> Date: Mon, 26 Nov 2012 11:21:33 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Linus Walleij CC: Rabin Vincent , Samuel Ortiz , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled References: <20121112164431.8bcfe78d2a2ec73271733db4@canb.auug.org.au> <50A12FF1.4000800@infradead.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2146 Lines: 61 On 11/13/2012 05:35 AM, Linus Walleij wrote: > On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Fix build errors when CONFIG_OF is not enabled by including >> (needs to be added in any case). >> An alternative fix could be to make the driver depend on OF. >> >> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32' >> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node' >> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token >> >> Signed-off-by: Randy Dunlap >> Cc: Rabin Vincent >> Cc: Samuel Ortiz > > Acked-by: Linus Walleij ping? This patch is still needed in linux-next. --- From: Randy Dunlap Fix build errors when CONFIG_OF is not enabled by including (needs to be added in any case). An alternative fix could be to make the driver depend on OF. drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32' drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node' drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token Signed-off-by: Randy Dunlap Cc: Rabin Vincent Cc: Samuel Ortiz Acked-by: Linus Walleij --- drivers/mfd/stmpe.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20121112.orig/drivers/mfd/stmpe.c +++ linux-next-20121112/drivers/mfd/stmpe.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/