Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933008Ab2K0AmA (ORCPT ); Mon, 26 Nov 2012 19:42:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40105 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495Ab2K0Al7 (ORCPT ); Mon, 26 Nov 2012 19:41:59 -0500 Date: Mon, 26 Nov 2012 16:41:57 -0800 From: Andrew Morton To: Cyrill Gorcunov Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Pavel Emelyanov , James Bottomley , Matthew Helsley , aneesh.kumar@linux.vnet.ibm.com, bfields@fieldses.org, oleg@redhat.com, rientjes@google.com, tvrtko.ursulin@onelan.co.uk, Andrey Vagin Subject: Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6 Message-Id: <20121126164157.c7f86ee6.akpm@linux-foundation.org> In-Reply-To: <20121114152239.936025193@openvz.org> References: <20121114151937.344922058@openvz.org> <20121114152239.936025193@openvz.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 36 On Wed, 14 Nov 2012 19:19:44 +0400 Cyrill Gorcunov wrote: > This allow us to print out fsnotify details such as > watchee inode, device, mask and optionally a file handle. This helps the compiler quite a lot: --- a/fs/notify/fdinfo.c~fs-notify-add-procfs-fdinfo-helper-v7-fix +++ a/fs/notify/fdinfo.c @@ -26,13 +26,13 @@ static int show_fdinfo(struct seq_file * struct fsnotify_mark *mark; int ret = 0; - spin_lock(&group->mark_lock); + mutex_lock(&group->mark_mutex); list_for_each_entry(mark, &group->marks_list, g_list) { ret = show(m, mark); if (ret) break; } - spin_unlock(&group->mark_lock); + mutex_unlock(&group->mark_mutex); return ret; } But I rather worry that the code which you sent clearly wasn't the code which you tested. Please retest and confirm that I now have the correct code? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/