Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758006Ab2K0GZc (ORCPT ); Tue, 27 Nov 2012 01:25:32 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:51923 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757895Ab2K0GZ3 convert rfc822-to-8bit (ORCPT ); Tue, 27 Nov 2012 01:25:29 -0500 From: "Philip, Avinash" To: "Bedia, Vaibhav" , "Cousson, Benoit" CC: "thierry.reding@avionic-design.de" , "paul@pwsan.com" , "tony@atomide.com" , "linux@arm.linux.org.uk" , "Hiremath, Vaibhav" , "AnilKumar, Chimata" , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Nori, Sekhar" , "Hebbar, Gururaja" Subject: RE: [PATCH v3 03/10] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Thread-Topic: [PATCH v3 03/10] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Thread-Index: AQHNxt2EeUTleDNI/kaFZbNycy/8n5f3RlKggAP68ICAAD55gIAAItEAgAGbnbA= Date: Tue, 27 Nov 2012 06:24:03 +0000 Deferred-Delivery: Tue, 27 Nov 2012 06:24:00 +0000 Message-ID: <518397C60809E147AF5323E0420B992E3E9EFFAC@DBDE01.ent.ti.com> References: <1353387831-31538-1-git-send-email-avinashphilip@ti.com> <1353387831-31538-4-git-send-email-avinashphilip@ti.com> <518397C60809E147AF5323E0420B992E3E9EEA8C@DBDE01.ent.ti.com> <50B33043.2020700@ti.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.162.25] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2312 Lines: 52 On Mon, Nov 26, 2012 at 16:37:36, Bedia, Vaibhav wrote: > Hi Benoit, > > On Mon, Nov 26, 2012 at 14:32:59, Cousson, Benoit wrote: > > Hi Vaibhav, > > > > On 11/26/2012 06:19 AM, Bedia, Vaibhav wrote: > > > On Fri, Nov 23, 2012 at 16:36:06, Philip, Avinash wrote: > > >> On Tue, Nov 20, 2012 at 10:33:44, Philip, Avinash wrote: > > >>> As part of PWM subsystem integration, PWM subsystem are sharing > > >>> resources like clock across submodules (ECAP, EQEP & EHRPWM). > > >>> To handle resource sharing & IP integration > > >>> 1. Rework on parent child relation between PWMSS and > > >>> ECAP, EQEP & EHRPWM child devices to support runtime PM. > > >>> 2. Add support for opt_clks in EHRPWM HWMOD entry to handle additional > > >>> clock gating from control module. > > >>> 3. Add HWMOD entries for EQEP PWM submodule. > > >>> > > >> > > >> Is there any review on this patch? > > >> This patch depends on ECAP & EHRPWM to work in am335x. > > > > > > First of all, I think you should break up this patch as per the 3 points > > > that you mentioned above. I will split the patches into 2. 1. One for correcting hwmod entries plus adding EQEP HWMOD entry 2. Adding parent child relation in hwmod entry. > > > > > > The usage of opt_clks for this does not look right to me. Based on your > > > description this clock is necessary and not optional on AM335x and on > > > Davinci platforms this clock does not exist. > > I checked the DA830 TRM and looks like TBCLK for eHRPWM is an always on clock > there. So, the only difference in AM335x is an additional enable bit. > > Instead of adding this as opt_clk in hwmod, we could add an always on clock node > in Davinci clock data and have the driver always do a clk_enable() on the tbclk > as part of the probe sequence. On AM335x, with the right clock node this will enable > the clock in hardware and on DA830 it turns into a NOP. This way we can avoid adding > the opt_clk entry in hwmod of eHRPWM. I will remove opt_clk in HWMOD and made tbclk is a mandatory clock in EHRPWM driver. Thanks Avinash -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/