Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758180Ab2K0HRV (ORCPT ); Tue, 27 Nov 2012 02:17:21 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:46533 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758103Ab2K0HRU (ORCPT ); Tue, 27 Nov 2012 02:17:20 -0500 MIME-Version: 1.0 In-Reply-To: <1353995979-28792-1-git-send-email-prabhakar.lad@ti.com> References: <1353995979-28792-1-git-send-email-prabhakar.lad@ti.com> Date: Tue, 27 Nov 2012 16:17:19 +0900 X-Google-Sender-Auth: XnKR67gtngzpilQAc_bhnkb-ViU Message-ID: Subject: Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c From: Kyungmin Park To: Prabhakar Lad Cc: LMML , LKML , Mauro Carvalho Chehab , Marek Szyprowski , Pawel Osciak , "Lad, Prabhakar" , Manjunath Hadli Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2268 Lines: 62 Hi, Does it right to use CONFIG_HAVE_GENERIC_DMA_COHERENT? it defined at init/Kconfig config HAVE_GENERIC_DMA_COHERENT bool default n and use at C file or header file as CONFIG_ prefix? e.g., include/asm-generic/dma-coherent.h:#ifdef CONFIG_HAVE_GENERIC_DMA_COHERENT Thank you, Kyungmin Park On 11/27/12, Prabhakar Lad wrote: > From: Lad, Prabhakar > > from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds > a check HAVE_GENERIC_DMA_COHERENT for dma ops, the check was wrongly > made it should have been HAVE_GENERIC_DMA_COHERENT but it was > CONFIG_HAVE_GENERIC_DMA_COHERENT. > This patch fixes the typo, which was causing following build error: > > videobuf2-dma-contig.c:743: error: 'vb2_dc_get_dmabuf' undeclared here (not > in a function) > make[3]: *** [drivers/media/v4l2-core/videobuf2-dma-contig.o] Error 1 > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > --- > drivers/media/v4l2-core/videobuf2-dma-contig.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c > b/drivers/media/v4l2-core/videobuf2-dma-contig.c > index 5729450..dfea692 100644 > --- a/drivers/media/v4l2-core/videobuf2-dma-contig.c > +++ b/drivers/media/v4l2-core/videobuf2-dma-contig.c > @@ -739,7 +739,7 @@ static void *vb2_dc_attach_dmabuf(void *alloc_ctx, > struct dma_buf *dbuf, > const struct vb2_mem_ops vb2_dma_contig_memops = { > .alloc = vb2_dc_alloc, > .put = vb2_dc_put, > -#ifdef CONFIG_HAVE_GENERIC_DMA_COHERENT > +#ifdef HAVE_GENERIC_DMA_COHERENT > .get_dmabuf = vb2_dc_get_dmabuf, > #endif > .cookie = vb2_dc_cookie, > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/