Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933435Ab2K0KKX (ORCPT ); Tue, 27 Nov 2012 05:10:23 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:48929 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933278Ab2K0KKU (ORCPT ); Tue, 27 Nov 2012 05:10:20 -0500 From: Peter Ujfalusi To: Thierry Reding CC: Tero Kristo , Grazvydas Ignotas , , , Linus Walleij , , Grant Likely , Rob Herring , Rob Landley , Subject: [PATCH v4 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs Date: Tue, 27 Nov 2012 11:09:56 +0100 Message-ID: <1354010999-31371-1-git-send-email-peter.ujfalusi@ti.com> X-Mailer: git-send-email 1.8.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2913 Lines: 71 Hello, Changes since v3: - pwm-twl-led driver's comment fix patch squashed to the original patch - Documentation for the DT bindings of the PWM drivers Comments from Thierry Reding addressed: - pwm-twl6030 has been removed in the last patch - macro for twl_pwm_chip/twl_pwmled_chip lookup - locking for read-modify-write sequences - separate pwm_ops strictures for twl4030 and twl6030 class - _devexit_P() removed - Do not select HAVE_PWM in Kconfig file since it is going away AFAIK: https://patchwork.kernel.org/patch/1544851/ - Remaining (smaller) comments from Thierry also has been addressed. Changes since v2: - New PWM cycle calculation for twl-pwm driver and twl4030's pwm-twl-led with comment to document the expected behaviour. Changes cince v1: - The turn on/off sequence has been corrected for twl4030 PWMs as suggested by Grazvydas Ignotas - Comment section added to the new drivers to describe what they are controlling The series has been tested (with additional, pending patches): Zoom2 for twl4030 PWM0 (keypad light), PWM1 (LCD backlight) BeagleBoard for twl4030 LEDB (PWMB - pmu_stat led) OMAP4 Blaze (SDP4430) for twl6030 PWM1 (keypad light), PWM2 (LCD backlight) and LED (charging indication led). Intro mail from v1: The currently available pwm-twl6030.c driver only supports TWL6030's Charging indication LED. Remove this driver and add two new ones which implements support for all PWM driven outputs: pwm-twl driver supports twl4030 (PWM 0/1) and twl6030 (PWM 1/2) instances pwm-twl-led driver supports twl4030 (PWM driven LED A/B ports) and twl6030's Charging indication LED (PWM driven). Regards, Peter --- Peter Ujfalusi (3): pwm: New driver to support PWMs on TWL4030/6030 series of PMICs pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs pwm: Remove pwm-twl6030 driver .../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 + .../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 + drivers/pwm/Kconfig | 17 +- drivers/pwm/Makefile | 3 +- drivers/pwm/pwm-twl-led.c | 342 ++++++++++++++++++++ drivers/pwm/pwm-twl.c | 357 +++++++++++++++++++++ drivers/pwm/pwm-twl6030.c | 184 ----------- 7 files changed, 748 insertions(+), 189 deletions(-) create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt create mode 100644 drivers/pwm/pwm-twl-led.c create mode 100644 drivers/pwm/pwm-twl.c delete mode 100644 drivers/pwm/pwm-twl6030.c -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/