Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755583Ab2K0Lry (ORCPT ); Tue, 27 Nov 2012 06:47:54 -0500 Received: from ns.km20343-01.keymachine.de ([84.19.182.79]:49401 "EHLO km20343-01.keymachine.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754818Ab2K0Lrw (ORCPT ); Tue, 27 Nov 2012 06:47:52 -0500 Message-ID: <1354016870.1479.41.camel@tellur> Subject: Re: [RFC v2 8/8] drm: tegra: Add gr2d device From: Lucas Stach To: Terje =?ISO-8859-1?Q?Bergstr=F6m?= Cc: Thierry Reding , Dave Airlie , "linux-tegra@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Arto Merilainen Date: Tue, 27 Nov 2012 12:47:50 +0100 In-Reply-To: <50B4A483.8030305@nvidia.com> References: <1353935954-13763-1-git-send-email-tbergstrom@nvidia.com> <1353935954-13763-9-git-send-email-tbergstrom@nvidia.com> <50B46336.8030605@nvidia.com> <50B476E1.4070403@nvidia.com> <50B47DA8.60609@nvidia.com> <1354011776.1479.31.camel@tellur> <20121127103739.GA3329@avionic-0098.adnet.avionic-design.de> <50B4A483.8030305@nvidia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1884 Lines: 40 Am Dienstag, den 27.11.2012, 13:31 +0200 schrieb Terje Bergström: > On 27.11.2012 12:37, Thierry Reding wrote: > > But in that case it should be made mandatory at first until proper IOMMU > > support is enabled on Tegra30. Then it can be checked at driver probe > > time whether or not to enable the extra checks. That way we don't need a > > special Kconfig option and we still get all the security that we need, > > right? > > I guess it depends on the level of security. > > If we want to only protect kernel and user space memory, this would be > sufficient and no firewall is needed if IOMMU is turned on. > > If we want to protect 2D buffers from each other, this is not sufficient. > I guess we could change IOMMU address spaces for the graphics units depending on the active channel. This would still be a bit of a performance hit, because of the necessary TLB flushing and so on, but should be much better than checking the whole command stream. This way you at least get security on a process level, as no process is able to corrupt another processes graphics resources. This is the same level of security as provided by the nouveau driver. But to do so all memory management has to be done in kernel and from the current submissions of the 2D infrastructure I fear that the current architecture does too much of that in userspace, but I'll hold back with any judgement until we actually get to see the userspace parts. Also to implement this strategy you have to take ownership of the graphics address space on a much lower level than the DMA API. This might take some work together with the IOMMU guys. Regards, Lucas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/