Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755729Ab2K0Txh (ORCPT ); Tue, 27 Nov 2012 14:53:37 -0500 Received: from smtp111.dfw.emailsrvr.com ([67.192.241.111]:50366 "EHLO smtp111.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755503Ab2K0Txf (ORCPT ); Tue, 27 Nov 2012 14:53:35 -0500 Message-ID: <50B51A41.8030006@calxeda.com> Date: Tue, 27 Nov 2012 13:53:37 -0600 From: Mark Langsdorf User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Thomas Petazzoni CC: "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Omar Ramirez Luna , Arnd Bergmann , Rob Herring Subject: Re: [PATCH 4/6 v5] arm highbank: add support for pl320 IPC References: <1351631056-25938-1-git-send-email-mark.langsdorf@calxeda.com> <1354028674-23685-1-git-send-email-mark.langsdorf@calxeda.com> <1354028674-23685-5-git-send-email-mark.langsdorf@calxeda.com> <20121127171250.3984e990@skate> In-Reply-To: <20121127171250.3984e990@skate> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 28 On 11/27/2012 10:12 AM, Thomas Petazzoni wrote: > Dear Mark Langsdorf, > > On Tue, 27 Nov 2012 09:04:32 -0600, Mark Langsdorf wrote: > >> +int ipc_transmit(u32 *data); > > ipc_transmit() looks to me like a way to generic name to be exposed to > the entire kernel. Good point. Changed to pl320_ipc_transmit() >> +extern int pl320_ipc_register_notifier(struct notifier_block *nb); >> +extern int pl320_ipc_unregister_notifier(struct notifier_block *nb); > > Why some "extern" here? You don't have these for the other functions in > this header file. Nice catch. Fixed to export them in cpufreq. --Mark Langsdorf Calxeda, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/