Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631Ab2K1QGv (ORCPT ); Wed, 28 Nov 2012 11:06:51 -0500 Received: from mail-vc0-f174.google.com ([209.85.220.174]:41626 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699Ab2K1QGu (ORCPT ); Wed, 28 Nov 2012 11:06:50 -0500 MIME-Version: 1.0 In-Reply-To: References: <1354103571-27394-1-git-send-email-rabin.vincent@stericsson.com> Date: Wed, 28 Nov 2012 21:36:49 +0530 X-Google-Sender-Auth: okPQr8Xf93f_8FHhRuthHHFgl2s Message-ID: Subject: Re: [RFC 1/2] clk: use struct clk only for external API From: viresh kumar To: Rabin Vincent Cc: Mike Turquette , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 20 On Wed, Nov 28, 2012 at 9:31 PM, viresh kumar wrote: > On Wed, Nov 28, 2012 at 5:22 PM, Rabin Vincent > Isn't something wrong here? For common clk case shouldn't > this be: > >> +#define clk_to_clk_core(clk) (&clk->clk) >> +#define clk_core_to_clk(core) (container_of(clk, ...)) //not getting into the exact format here > > Sorry, if i am missing basics. Ok. I saw these getting updated in 2/2. But it means this individual patch is broken and this is not allowed i believe. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/