Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043Ab2K1Qh0 (ORCPT ); Wed, 28 Nov 2012 11:37:26 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:64137 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071Ab2K1QhZ (ORCPT ); Wed, 28 Nov 2012 11:37:25 -0500 MIME-Version: 1.0 In-Reply-To: References: <1336004953.4240.9.camel@mop> From: Linus Torvalds Date: Wed, 28 Nov 2012 08:37:03 -0800 X-Google-Sender-Auth: 4bb5BEQuWA2vJusYil4GD3vw4vo Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Kay Sievers Cc: Michael Kerrisk , Greg Kroah-Hartmann , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 30 On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: > On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk wrote: > >> On a 2.6.31 system, immediately after SYSLOG_ACTION_READ_CLEAR, a >> SYSLOG_ACTION_SIZE_UNREAD returns 0. > > Hmm, sounds like the right thing to do. Right. And that's the *OLD* behavior (2.6.31). >> On 3.5, immediately after SYSLOG_ACTION_READ_CLEAR, the value returned >> by SYSLOG_ACTION_SIZE_UNREAD is unchanged And this is the *NEW* behavior, and as you say: > Which sounds at least like weird behaviour, if not "broken". So the new behavior is insane and different. Let's fix it. It looks like it is because the new SYSLOG_ACTION_SIZE_UNREAD code does not take the new clear_seq code into account. Hmm? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/