Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439Ab2K1Qtc (ORCPT ); Wed, 28 Nov 2012 11:49:32 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:39603 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754438Ab2K1Qt1 (ORCPT ); Wed, 28 Nov 2012 11:49:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1336004953.4240.9.camel@mop> From: Kay Sievers Date: Wed, 28 Nov 2012 17:49:06 +0100 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Linus Torvalds Cc: Michael Kerrisk , Greg Kroah-Hartmann , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 32 On Wed, Nov 28, 2012 at 5:37 PM, Linus Torvalds wrote: > On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: >> On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk wrote: >> >>> On a 2.6.31 system, immediately after SYSLOG_ACTION_READ_CLEAR, a >>> SYSLOG_ACTION_SIZE_UNREAD returns 0. >> >> Hmm, sounds like the right thing to do. > > Right. > > And that's the *OLD* behavior (2.6.31). Ah, hmm, I read 2.6... as 3.6... :) > So the new behavior is insane and different. Let's fix it. Yeah. > It looks like it is because the new SYSLOG_ACTION_SIZE_UNREAD code > does not take the new clear_seq code into account. Hmm? Right, something like that. I'll take a look now ... Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/