Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 12 Sep 2002 19:55:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 12 Sep 2002 19:55:59 -0400 Received: from dsl-213-023-039-132.arcor-ip.net ([213.23.39.132]:49034 "EHLO starship") by vger.kernel.org with ESMTP id ; Thu, 12 Sep 2002 19:55:58 -0400 Content-Type: text/plain; charset=US-ASCII From: Daniel Phillips To: Rik van Riel , Andrew Morton Subject: Re: invalidate_inode_pages in 2.5.32/3 Date: Fri, 13 Sep 2002 01:53:08 +0200 X-Mailer: KMail [version 1.3.2] Cc: Urban Widmark , Chuck Lever , , Linux Kernel Mailing List References: In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Message-Id: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 28 On Friday 13 September 2002 01:23, Rik van Riel wrote: > On Thu, 12 Sep 2002, Andrew Morton wrote: > > Rik van Riel wrote: > > > > invalidate_page(struct page * page) { > > > That's the bottom-up approach. The top-down (vmtruncate) approach > > would also work, if the locking is suitable. > > The top-down approach will almost certainly be most efficient when > invalidating a large chunk of a file (truncate, large file locks) > while the bottom-up approach is probably more efficient when the > system invalidates very few pages (small file lock, cluster file > system mmap() support). The bottom-up approach is the one we want to use when we'd otherwise skip a page in invalidate_inode_pages. This is the rare case. On the face of it, this works out very well. Just have to think about interactions now - I don't see any, but I haven't really gone hunting yet. -- Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/