Date: Wed, 28 Nov 2012 20:04:36 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
        acme@redhat.com, peterz@infradead.org, eranian@google.com,
        mingo@kernel.org, namhyung@kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 31/32] perf, tools: Default to cpu// for events v3
Message-ID: <20121128190436.GR16230@one.firstfloor.org>
References: <1352510868-7911-1-git-send-email-andi@firstfloor.org> <1352510868-7911-32-git-send-email-andi@firstfloor.org> <20121128155313.GF1038@krava.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121128155313.GF1038@krava.brq.redhat.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 969
Lines: 38

> > +static void str_append(char **s, int *len, const char *a)
> > +{
> > +	int olen = *s ? strlen(*s) : 0;
> > +	int nlen = olen + strlen(a) + 1;
> > +	if (*len < nlen) {
> > +		*len = *len * 2;
> > +		if (*len < nlen)
> > +			*len = nlen;
> > +		*s = realloc(*s, *len);
> > +		if (!*s)
> > +			exit(ENOMEM);
> 
> Rather use BUG_ON or event better return -ENOMEM.

Neither makes sense: the callers won't handle it and it's not a bug.
If you're out of memory in user space the only thing you can do is to 
exit.

> 
> > +		if (olen == 0)
> > +			**s = 0;
> > +	}
> > +	strcat(*s, a);
> > +}
> 
> Could this one be moved to util/string.c in some generic form?

Ok.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/