Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755897Ab2K1THz (ORCPT ); Wed, 28 Nov 2012 14:07:55 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:40533 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006Ab2K1THy (ORCPT ); Wed, 28 Nov 2012 14:07:54 -0500 MIME-Version: 1.0 In-Reply-To: <50B64996.1010709@redhat.com> References: <50A513A8.9010404@redhat.com> <50B63A04.9010901@redhat.com> <50B64996.1010709@redhat.com> From: Linus Torvalds Date: Wed, 28 Nov 2012 11:07:32 -0800 X-Google-Sender-Auth: 1s47g94Kid9Zg4ewzkKTVNGxJqU Message-ID: Subject: Re: Acpi deadlocks with 3.7.0-rc4 To: Zdenek Kabelac Cc: Len Brown , "Rafael J. Wysocki" , Linux ACPI , LKML Content-Type: multipart/mixed; boundary=e89a8f2355c71eeb9e04cf92e20b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2341 Lines: 56 --e89a8f2355c71eeb9e04cf92e20b Content-Type: text/plain; charset=ISO-8859-1 On Wed, Nov 28, 2012 at 9:27 AM, Zdenek Kabelac wrote: > > I've attached bigger disasfun script output to BZ 51071. > https://bugzilla.kernel.org/show_bug.cgi?id=51071#c1 > > > if (ACPI_GET_DESCRIPTOR_TYPE(prefix_node) != > 00000000000000a1 cmpb $0xf,0x8(%rbx) > 00000000000000a5 je 0da > > seems to be going out of bounds. The whole "prefix_node" pointer is bogus. It seems to have the value 0x1000. I wonder how that happened. It's loaded from 'scope_info->scope.node', and it *should* be a valid pointer. Can you add a print-out of scope_info->common.descriptor_type and check that it is ACPI_DESC_TYPE_STATE_WSCOPE (== 8). If it is not, return early. Or just something like the attatched, which just uses the root node (and warns once) if it's not a valid WSCOPE thing. Linus --e89a8f2355c71eeb9e04cf92e20b Content-Type: application/octet-stream; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ha2tt2ni0 IGRyaXZlcnMvYWNwaS9hY3BpY2EvbnNhY2Nlc3MuYyB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2FjcGkvYWNwaWNhL25zYWNjZXNz LmMgYi9kcml2ZXJzL2FjcGkvYWNwaWNhL25zYWNjZXNzLmMKaW5kZXggMjNkYjUzY2UyMjkzLi4z MjM4Y2FiYmE2MWEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvYWNwaS9hY3BpY2EvbnNhY2Nlc3MuYwor KysgYi9kcml2ZXJzL2FjcGkvYWNwaWNhL25zYWNjZXNzLmMKQEAgLTMyMCw2ICszMjAsOCBAQCBh Y3BpX25zX2xvb2t1cCh1bmlvbiBhY3BpX2dlbmVyaWNfc3RhdGUgKnNjb3BlX2luZm8sCiAJCQkJ ICBhY3BpX2dibF9yb290X25vZGUpKTsKIAogCQlwcmVmaXhfbm9kZSA9IGFjcGlfZ2JsX3Jvb3Rf bm9kZTsKKwl9IGVsc2UgaWYgKFdBUk5fT05fT05DRShzY29wZV9pbmZvLT5jb21tb24uZGVzY3Jp cHRvcl90eXBlICE9IEFDUElfREVTQ19UWVBFX1NUQVRFX1dTQ09QRSkpIHsKKwkJcHJlZml4X25v ZGUgPSBhY3BpX2dibF9yb290X25vZGU7CiAJfSBlbHNlIHsKIAkJcHJlZml4X25vZGUgPSBzY29w ZV9pbmZvLT5zY29wZS5ub2RlOwogCQlpZiAoQUNQSV9HRVRfREVTQ1JJUFRPUl9UWVBFKHByZWZp eF9ub2RlKSAhPQo= --e89a8f2355c71eeb9e04cf92e20b-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/