Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108Ab2K1VYm (ORCPT ); Wed, 28 Nov 2012 16:24:42 -0500 Received: from shrek-wifi.podlesie.net ([93.179.225.50]:55439 "EHLO shrek.podlesie.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080Ab2K1VYl (ORCPT ); Wed, 28 Nov 2012 16:24:41 -0500 Date: Wed, 28 Nov 2012 22:24:38 +0100 From: Krzysztof Mazur To: David Woodhouse Cc: chas williams - CONTRACTOR , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc Message-ID: <20121128212438.GA941@shrek.podlesie.net> References: <1350926091-12642-1-git-send-email-krzysiek@podlesie.net> <1350926091-12642-3-git-send-email-krzysiek@podlesie.net> <1354036592.2534.6.camel@shinybook.infradead.org> <20121127173906.GA11390@shrek.podlesie.net> <1354039349.2534.11.camel@shinybook.infradead.org> <20121127182843.GA11597@shrek.podlesie.net> <20121128201837.GA912@shrek.podlesie.net> <1354135481.21562.98.camel@shinybook.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1354135481.21562.98.camel@shinybook.infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 635 Lines: 19 On Wed, Nov 28, 2012 at 08:44:41PM +0000, David Woodhouse wrote: > On Wed, 2012-11-28 at 21:18 +0100, Krzysztof Mazur wrote: > > > > +void vcc_pop_any(struct atm_vcc *vcc, struct sk_buff *skb) > > +{ > > + if (vcc->pop) > > + vcc->pop(vcc, skb); > > if (vcc && vcc->pop) perhaps? > yes, we can do that, at least "he" and "nicstar" use that in some cases. Krzysiek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/