Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135Ab2K1V04 (ORCPT ); Wed, 28 Nov 2012 16:26:56 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:64316 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754831Ab2K1V0y (ORCPT ); Wed, 28 Nov 2012 16:26:54 -0500 MIME-Version: 1.0 In-Reply-To: References: <1354103571-27394-1-git-send-email-rabin.vincent@stericsson.com> From: Rabin Vincent Date: Wed, 28 Nov 2012 22:26:12 +0100 X-Google-Sender-Auth: Sd0R5Zyk-puOyRUF6O9-_NJUtKc Message-ID: Subject: Re: [RFC 1/2] clk: use struct clk only for external API To: viresh kumar Cc: Mike Turquette , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 22 2012/11/28 viresh kumar : > On Wed, Nov 28, 2012 at 9:31 PM, viresh kumar wrote: >> On Wed, Nov 28, 2012 at 5:22 PM, Rabin Vincent >> Isn't something wrong here? For common clk case shouldn't >> this be: >> >>> +#define clk_to_clk_core(clk) (&clk->clk) >>> +#define clk_core_to_clk(core) (container_of(clk, ...)) //not getting into the exact format here >> >> Sorry, if i am missing basics. > > Ok. I saw these getting updated in 2/2. But it means this individual patch > is broken and this is not allowed i believe. It would be better to use container_of / &clk->clk, yes. I wouldn't really describe it as "broken" though since it works fine as it is, since it's the first and only element. I will change it anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/