Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756153Ab2K1VkA (ORCPT ); Wed, 28 Nov 2012 16:40:00 -0500 Received: from terminus.zytor.com ([198.137.202.10]:40403 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754726Ab2K1Vj6 (ORCPT ); Wed, 28 Nov 2012 16:39:58 -0500 Message-ID: <50B68467.5020008@zytor.com> Date: Wed, 28 Nov 2012 13:38:47 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Luck, Tony" CC: Jiang Liu , Tang Chen , "akpm@linux-foundation.org" , "rob@landley.net" , "isimatu.yasuaki@jp.fujitsu.com" , "laijs@cn.fujitsu.com" , "wency@cn.fujitsu.com" , "linfeng@cn.fujitsu.com" , "yinghai@kernel.org" , "kosaki.motohiro@jp.fujitsu.com" , "minchan.kim@gmail.com" , "mgorman@suse.de" , "rientjes@google.com" , "rusty@rustcorp.com.au" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , Len Brown , "Wang, Frank" Subject: Re: [PATCH v2 0/5] Add movablecore_map boot option References: <1353667445-7593-1-git-send-email-tangchen@cn.fujitsu.com> <50B5CFAE.80103@huawei.com> <3908561D78D1C84285E8C5FCA982C28F1C95EDCE@ORSMSX108.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F1C95EDCE@ORSMSX108.amr.corp.intel.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 35 On 11/28/2012 01:34 PM, Luck, Tony wrote: >> >> 2. use boot option >> This is our proposal. New boot option can specify memory range to use >> as movable memory. > > Isn't this just moving the work to the user? To pick good values for the > movable areas, they need to know how the memory lines up across > node boundaries ... because they need to make sure to allow some > non-movable memory allocations on each node so that the kernel can > take advantage of node locality. > > So the user would have to read at least the SRAT table, and perhaps > more, to figure out what to provide as arguments. > > Since this is going to be used on a dynamic system where nodes might > be added an removed - the right values for these arguments might > change from one boot to the next. So even if the user gets them right > on day 1, a month later when a new node has been added, or a broken > node removed the values would be stale. > I gave this feedback in person at LCE: I consider the kernel configuration option to be useless for anything other than debugging. Trying to promote it as an actual solution, to be used by end users in the field, is ridiculous at best. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/