Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756190Ab2K1WKp (ORCPT ); Wed, 28 Nov 2012 17:10:45 -0500 Received: from shrek-wifi.podlesie.net ([93.179.225.50]:36837 "EHLO shrek.podlesie.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755683Ab2K1WKo (ORCPT ); Wed, 28 Nov 2012 17:10:44 -0500 Date: Wed, 28 Nov 2012 23:10:40 +0100 From: Krzysztof Mazur To: chas williams - CONTRACTOR Cc: David Woodhouse , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: introduce vcc_pop() Message-ID: <20121128221040.GA24035@shrek.podlesie.net> References: <1350926091-12642-1-git-send-email-krzysiek@podlesie.net> <1350926091-12642-3-git-send-email-krzysiek@podlesie.net> <1354036592.2534.6.camel@shinybook.infradead.org> <20121127173906.GA11390@shrek.podlesie.net> <1354039349.2534.11.camel@shinybook.infradead.org> <20121127182843.GA11597@shrek.podlesie.net> <20121128201837.GA912@shrek.podlesie.net> <20121128162001.3f326720@thirdoffive.cmf.nrl.navy.mil> <20121128214533.GA25486@shrek.podlesie.net> <20121128165906.05ef5e2b@thirdoffive.cmf.nrl.navy.mil> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121128165906.05ef5e2b@thirdoffive.cmf.nrl.navy.mil> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3033 Lines: 98 On Wed, Nov 28, 2012 at 04:59:06PM -0500, chas williams - CONTRACTOR wrote: > On Wed, 28 Nov 2012 22:45:34 +0100 > Krzysztof Mazur wrote: > > > On Wed, Nov 28, 2012 at 04:20:01PM -0500, chas williams - CONTRACTOR wrote: > > > i dont like the vcc->pop() implementation and at one point i had the > > > crazy idea of using skb->destructors to handle it. however, i think it > > > would be necessary to clone the skb's so any existing destructor is > > > preserved. > > > > With this patch we will kill vcc->pop() in drivers and in future > > we can do that without changes in drivers. > > ok > > > > > > > > +#define vcc_pop(vcc, skb) vcc_pop_any(vcc, skb) > > > > +#define vcc_pop_irq(vcc, skb) vcc_pop_any(vcc, skb) > > > > > > don't define these if you dont plan on using them anway. > > > > I removed them. I also added check if vcc is NULL, as David Woodhouse > > suggested, some drivers use that. > > it should probably be if (likely(vcc) && likely(vcc->pop)) since it > will almost always be the case. Thanks, Krzysiek -- >8 -- Subject: [PATCH v3] atm: introduce vcc_pop() The atm drivers to free skb, that they got from ->send(), cannot just use dev_kfree_skb*(), but they must use something like: if (vcc->pop) vcc->pop(vcc, skb); else dev_kfree_skb_any(skb); When vcc->pop() is non-NULL, but they must in such case call vcc->pop(). This causes duplicated code in many drivers, and some drivers even forgot to call vcc->pop() in some error handling code. Signed-off-by: Krzysztof Mazur --- include/linux/atmdev.h | 8 ++++++++ net/atm/common.c | 9 +++++++++ 2 files changed, 17 insertions(+) diff --git a/include/linux/atmdev.h b/include/linux/atmdev.h index c1da539..57bd93f 100644 --- a/include/linux/atmdev.h +++ b/include/linux/atmdev.h @@ -283,6 +283,14 @@ int atm_pcr_goal(const struct atm_trafprm *tp); void vcc_release_async(struct atm_vcc *vcc, int reply); +/** + * vcc_pop - free transmitted ATM skb + * + * vcc_pop() should be used by ATM driver to free skbs, that were sent + * to driver by atmdev_opt->send() function. + */ +void vcc_pop(struct atm_vcc *vcc, struct sk_buff *skb); + struct atm_ioctl { struct module *owner; /* A module reference is kept if appropriate over this call. diff --git a/net/atm/common.c b/net/atm/common.c index 806fc0a..c42ff62 100644 --- a/net/atm/common.c +++ b/net/atm/common.c @@ -654,6 +654,15 @@ out: return error; } +void vcc_pop(struct atm_vcc *vcc, struct sk_buff *skb) +{ + if (likely(vcc) && likely(vcc->pop)) + vcc->pop(vcc, skb); + else + dev_kfree_skb_any(skb); +} +EXPORT_SYMBOL(vcc_pop); + unsigned int vcc_poll(struct file *file, struct socket *sock, poll_table *wait) { struct sock *sk = sock->sk; -- 1.8.0.411.g71a7da8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/