Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756267Ab2K2AOz (ORCPT ); Wed, 28 Nov 2012 19:14:55 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:32831 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018Ab2K2AOy (ORCPT ); Wed, 28 Nov 2012 19:14:54 -0500 Date: Wed, 28 Nov 2012 16:14:52 -0800 From: Andrew Morton To: Mel Gorman Cc: Linus Torvalds , Johannes Weiner , Rik van Riel , George Spelvin , Johannes Hirte , Tomas Racek , Jan Kara , Dave Hansen , Josh Boyer , Valdis Kletnieks , Jiri Slaby , Thorsten Leemhuis , Zdenek Kabelac , Bruno Wolff III , linux-mm , Linux Kernel Mailing List Subject: Re: kswapd craziness in 3.7 Message-Id: <20121128161452.c1ddc9a3.akpm@linux-foundation.org> In-Reply-To: <20121128235412.GW8218@suse.de> References: <1354049315-12874-1-git-send-email-hannes@cmpxchg.org> <50B52DC4.5000109@redhat.com> <20121127214928.GA20253@cmpxchg.org> <50B5387C.1030005@redhat.com> <20121127222637.GG2301@cmpxchg.org> <20121128101359.GT8218@suse.de> <20121128145215.d23aeb1b.akpm@linux-foundation.org> <20121128235412.GW8218@suse.de> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2645 Lines: 62 On Wed, 28 Nov 2012 23:54:12 +0000 Mel Gorman wrote: > On Wed, Nov 28, 2012 at 02:52:15PM -0800, Andrew Morton wrote: > > On Wed, 28 Nov 2012 10:13:59 +0000 > > Mel Gorman wrote: > > > > > Based on the reports I've seen I expect the following to work for 3.7 > > > > > > Keep > > > 96710098 mm: revert "mm: vmscan: scale number of pages reclaimed by reclaim/compaction based on failures" > > > ef6c5be6 fix incorrect NR_FREE_PAGES accounting (appears like memory leak) > > > > > > Revert > > > 82b212f4 Revert "mm: remove __GFP_NO_KSWAPD" > > > > > > Merge > > > mm: vmscan: fix kswapd endless loop on higher order allocation > > > mm: Avoid waking kswapd for THP allocations when compaction is deferred or contended > > > > "mm: Avoid waking kswapd for THP ..." is marked "I have not tested it > > myself" and when Zdenek tested it he hit an unexplained oom. > > > > I thought Zdenek was testing with __GFP_NO_KSWAPD when he hit that OOM. > Further, when he hit that OOM, it looked like a genuine OOM. He had no > swap configured and inactive/active file pages were very low. Finally, > the free pages for Normal looked off and could also have been affected by > the accounting bug. I'm looking at https://lkml.org/lkml/2012/11/18/132 > here. Are you thinking of something else? who, me, think? I was trying to work out why I hadn't merged or queued a patch which you felt was important. Turned out it was because it didn't look very tested and final. > I have not tested with the patch admittedly but Thorsten has and seemed > to be ok with it https://lkml.org/lkml/2012/11/23/276. OK, I'll queue revert-revert-mm-remove-__gfp_no_kswapd.patch and the patch from https://patchwork.kernel.org/patch/1728081/. So what I'm currently sitting on for 3.7 is mm-compaction-fix-return-value-of-capture_free_page.patch mm-vmemmap-fix-wrong-use-of-virt_to_page.patch mm-vmscan-fix-endless-loop-in-kswapd-balancing.patch revert-revert-mm-remove-__gfp_no_kswapd.patch mm-avoid-waking-kswapd-for-thp-allocations-when-compaction-is-deferred-or-contended.patch mm-soft-offline-split-thp-at-the-beginning-of-soft_offline_page.patch > > Please identify "Johannes' patch"? > > mm: vmscan: fix kswapd endless loop on higher order allocation OK, we have that. I'll start a round of testing, do another -next drop and send the above Linuswards tomorrow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/