Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651Ab2K2Bi7 (ORCPT ); Wed, 28 Nov 2012 20:38:59 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:49749 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946Ab2K2Bi5 (ORCPT ); Wed, 28 Nov 2012 20:38:57 -0500 MIME-Version: 1.0 In-Reply-To: <20121128201804.GI31879@valkosipuli.retiisi.org.uk> References: <1354100134-21095-1-git-send-email-prabhakar.lad@ti.com> <1354100134-21095-3-git-send-email-prabhakar.lad@ti.com> <20121128201804.GI31879@valkosipuli.retiisi.org.uk> From: Prabhakar Lad Date: Thu, 29 Nov 2012 07:08:36 +0530 Message-ID: Subject: Re: [PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl To: Sakari Ailus Cc: LMML , Mauro Carvalho Chehab , LKML , DLOS , Manjunath Hadli , Prabhakar Lad , Laurent Pinchart , Hans Verkuil Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2570 Lines: 81 Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:48 AM, Sakari Ailus wrote: > Hi Prabhakar, > > On Wed, Nov 28, 2012 at 04:25:33PM +0530, Prabhakar Lad wrote: >> From: Manjunath Hadli >> >> request_mem_region for VPSS_CLK_CTRL register and ioremap. >> and enable clocks appropriately. >> >> Signed-off-by: Manjunath Hadli >> Signed-off-by: Lad, Prabhakar >> --- >> drivers/media/platform/davinci/vpss.c | 14 ++++++++++++++ >> 1 files changed, 14 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c >> index 34ad7bd..a36d694 100644 >> --- a/drivers/media/platform/davinci/vpss.c >> +++ b/drivers/media/platform/davinci/vpss.c >> @@ -103,6 +103,7 @@ struct vpss_hw_ops { >> struct vpss_oper_config { >> __iomem void *vpss_regs_base0; >> __iomem void *vpss_regs_base1; >> + resource_size_t *vpss_regs_base2; >> enum vpss_platform_type platform; >> spinlock_t vpss_lock; >> struct vpss_hw_ops hw_ops; >> @@ -484,11 +485,24 @@ static struct platform_driver vpss_driver = { >> >> static void vpss_exit(void) >> { >> + iounmap(oper_cfg.vpss_regs_base2); >> + release_mem_region(*oper_cfg.vpss_regs_base2, 4); > > release_mem_region(VPSS_CLK_CTRL, 4);? > Ok. >> platform_driver_unregister(&vpss_driver); >> } >> >> +#define VPSS_CLK_CTRL 0x01c40044 >> +#define VPSS_CLK_CTRL_VENCCLKEN BIT(3) >> +#define VPSS_CLK_CTRL_DACCLKEN BIT(4) >> + >> static int __init vpss_init(void) >> { >> + if (request_mem_region(VPSS_CLK_CTRL, 4, "vpss_clock_control")) { > > if (!request_mem_region()) > return -EBUSY; > Ok makes sense returning early on failure. Regards, --Prabhakar > ... > >> + oper_cfg.vpss_regs_base2 = ioremap(VPSS_CLK_CTRL, 4); >> + __raw_writel(VPSS_CLK_CTRL_VENCCLKEN | >> + VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2); >> + } else { >> + return -EBUSY; >> + } >> return platform_driver_register(&vpss_driver); >> } >> subsys_initcall(vpss_init); > > -- > Sakari Ailus > e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/