Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940Ab2K2J1J (ORCPT ); Thu, 29 Nov 2012 04:27:09 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:35407 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865Ab2K2J1H (ORCPT ); Thu, 29 Nov 2012 04:27:07 -0500 MIME-Version: 1.0 In-Reply-To: <20121129092308.GT2013@gmail.com> References: <20121129092308.GT2013@gmail.com> Date: Thu, 29 Nov 2012 14:57:05 +0530 Message-ID: Subject: Re: [PATCH V4 Resend 3/3] mfd: stmpe: Update DT support in stmpe driver From: Viresh Kumar To: Lee Jones Cc: sameo@linux.intel.com, grant.likely@secretlab.ca, rabin.vincent@stericsson.com, shiraz.hashim@st.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, linus.walleij@linaro.org, Vipul Kumar Samar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 18 On 29 November 2012 14:53, Lee Jones wrote: >> From: Vipul Kumar Samar >> + /* >> + * Distinct names of same cell-type within multiple instances of stmpe >> + * will be guaranteed by DT. >> + */ >> + pdata->id = -1; > > And what if we're not booting with DT? Then it is responsibility of code creating platform data for stmpe to fill it appropriately. i.e. If there is only one instance of stmpe on board, then better pass it as -1, else start counting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/