Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688Ab2K2N2X (ORCPT ); Thu, 29 Nov 2012 08:28:23 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:65469 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071Ab2K2N2W (ORCPT ); Thu, 29 Nov 2012 08:28:22 -0500 MIME-Version: 1.0 In-Reply-To: References: <1336004953.4240.9.camel@mop> <1354125084.20578.1.camel@nja> From: Kay Sievers Date: Thu, 29 Nov 2012 14:28:00 +0100 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: mtk.manpages@gmail.com Cc: Linus Torvalds , Greg Kroah-Hartmann , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 35 On Thu, Nov 29, 2012 at 2:18 PM, Michael Kerrisk (man-pages) wrote: > On Wed, Nov 28, 2012 at 6:51 PM, Kay Sievers wrote: >> Before: >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 286965 >> syslog(SYSLOG_ACTION_READ_CLEAR, "<12>"..., 1000000) = 24000 >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 286965 >> >> After: >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 90402 >> syslog(SYSLOG_ACTION_READ_CLEAR, "<5>"..., 1000000) = 90402 >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 0 > I'm going to call my report yesterday bogus. Somewhere along the way, > I got confused while testing something, and my statement about 2.6.31 > behavior is wrong: the 2.6.31 and 3.5 behaviors are the same. As such, > your patch is unneeded. Sorry for wasting your time. I think you have been right with your report. The above pasted before/after from the patch commit text is actually a result of real testing with current git. And your initial description sounds right, and the patch seems to produce the expected results here. I just confused the numbers in your report and wrongly parsed 2.6 > 3.6. Hmm, at least do far we did not blame anybody else than ourselves as confused. One of us at least is right, and it looks you have been, and I also think the patch is at least intended to be right. :) Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/