Date: Thu, 29 Nov 2012 10:06:27 -0600
From: Kent Yoder <key@linux.vnet.ibm.com>
To: Peter Huewe <PeterHuewe@gmx.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Rajiv Andrade <mail@srajiv.net>,
        Marcel Selhorst <tpmdd@selhorst.net>, Sirrix AG <tpmdd@sirrix.com>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char/tpm: Use true and false for bools
Message-ID: <20121129160627.GB15399@ennui.austin.ibm.com>
References: <1354148437-6446-1-git-send-email-peterhuewe@gmx.de>
 <20121129002519.GG4939@ZenIV.linux.org.uk>
 <201211290142.47502.PeterHuewe@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201211290142.47502.PeterHuewe@gmx.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 953
Lines: 31

On Thu, Nov 29, 2012 at 01:42:47AM +0100, Peter Huewe wrote:
> Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro:
> > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote:
> > > -		itpm = (probe == 0) ? 0 : 1;
> > > +		itpm = (probe == 0) ? false : true;
> > 
> > Charming.  Not that original had been better, but...
> Yeah. Sorry it's late.
> The tpm subsection has a lot of nice suprises.

 :-)  I'd prefer

 itpm = !!probe;

 Now I don't have to go look up what the possible return values of
probe_itpm() are...

Kent

> I changed it to itpm = probe; which is equivalent here and sent out a v2.
> I'll probably rewrite that code section anytime soon.
> 
> Thanks for noticing.
> Peter
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/