Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752911Ab2K2Syo (ORCPT ); Thu, 29 Nov 2012 13:54:44 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:33136 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187Ab2K2Sym (ORCPT ); Thu, 29 Nov 2012 13:54:42 -0500 MIME-Version: 1.0 In-Reply-To: <20121129132509.211c4977@corrin.poochiereds.net> References: <20121129173053.GQ27196@axis.com> <20121129132509.211c4977@corrin.poochiereds.net> Date: Thu, 29 Nov 2012 12:54:41 -0600 Message-ID: Subject: Re: [RFQ PATCH] cifs: Change default security error message From: Steve French To: Jeff Layton Cc: Jesper Nilsson , linux-cifs@vger.kernel.org, sfrench@samba.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2468 Lines: 62 On Thu, Nov 29, 2012 at 12:25 PM, Jeff Layton wrote: > On Thu, 29 Nov 2012 18:30:53 +0100 > Jesper Nilsson wrote: > >> Hi! >> >> Connecting with a default security mechanism prompts an KERN_ERROR >> output warning to the user that the default mechanism will be changed >> in Linux 3.3. >> >> We're now at 3.7, so we either could remove the warning completely >> (if the default has been changed), or we could bump the number to >> what our current target for the change is. >> >> >> The below patch changes the cERROR (which turns into a printk with KERN_ERROR) >> into a straight printk with KERN_WARNING and changes the text to indicate >> that it was changed in 3.3. >> >> I expect that the patch is incorrect and that we should choose >> another of the alternative solutions above, but I'd like to get >> some input on this. >> >> Not-Signed-off-by: Jesper Nilsson >> --- >> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c >> index c83f5b65..968456f 100644 >> --- a/fs/cifs/connect.c >> +++ b/fs/cifs/connect.c >> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info) >> supported for many years, time to update default security mechanism */ >> if ((volume_info->secFlg == 0) && warned_on_ntlm == false) { >> warned_on_ntlm = true; >> - cERROR(1, "default security mechanism requested. The default " >> - "security mechanism will be upgraded from ntlm to " >> - "ntlmv2 in kernel release 3.3"); >> + printk(KERN_WARNING "default security mechanism requested. " >> + "The default security mechanism was changed " >> + " from ntlm to ntlmv2 in kernel release 3.3"); >> } >> ses->overrideSecFlg = volume_info->secFlg; >> >> >> >> /^JN - Jesper Nilsson > > I think this warning has lived long enough and needs to go away. Steve > supposedly has a patch that finally makes this change, but it hasn't > been sent to the list yet... Steve? It was posted to list on November 25th (and you even included it in your git tree on samba.org ?!) -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/