Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755105Ab2K2X60 (ORCPT ); Thu, 29 Nov 2012 18:58:26 -0500 Received: from www.hansjkoch.de ([178.63.77.200]:51444 "EHLO www.hansjkoch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205Ab2K2X6Z (ORCPT ); Thu, 29 Nov 2012 18:58:25 -0500 Date: Fri, 30 Nov 2012 00:58:22 +0100 From: "Hans J. Koch" To: Vitalii Demianets Cc: Tux9 , "Hans J. Koch" , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized Message-ID: <20121129235822.GA2590@local> References: <201211271348.14603.vitas@nppfactor.kiev.ua> <201211291822.16565.vitas@nppfactor.kiev.ua> <201211291836.59358.vitas@nppfactor.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201211291836.59358.vitas@nppfactor.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2254 Lines: 64 On Thu, Nov 29, 2012 at 06:36:59PM +0200, Vitalii Demianets wrote: > > On Thursday 29 November 2012 18:05:27 Tux9 wrote: > > > Hans, I think there are something wrong in your patch, while Vitalii's > > > is right. The variable "ret" is reused in line 292 and line 295, so > > > the value of "ret" would be overridden (if it goto err_map in line 284 > > > when mi>=1). > > > > Actually, both patches do exactly the same thing. Hans's patch establishes > > default value for the ret for all those "other" cases when ret is not > > explicitly overridden. My patch explicitly enumerates all those "other" > > cases in more wordily manner. > > > > Oops, disregard this. After looking at it more thoroughly I got your point. > You are right, ret is overridden at first iteration (mi == 0), so Hans's > approach does not work. > I must do more thinking before replying in a hurry. You're right. Initialization of "ret" has to take place at the beginning of the loop. I think this version is right: >From 00c3c734c0dde67873a628bcb18cee403c95c301 Mon Sep 17 00:00:00 2001 From: "Hans J. Koch" Date: Fri, 30 Nov 2012 00:51:50 +0100 Subject: [PATCH] uio: Fix warning: 'ret' might be used uninitialized In two cases, the return value variable "ret" can be undefined. Signed-off-by: Hans J. Koch --- drivers/uio/uio.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 5110f36..0c80df2 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -273,6 +273,7 @@ static int uio_dev_add_attributes(struct uio_device *idev) struct uio_portio *portio; for (mi = 0; mi < MAX_UIO_MAPS; mi++) { + ret = -ENOMEM; mem = &idev->info->mem[mi]; if (mem->size == 0) break; @@ -298,6 +299,7 @@ static int uio_dev_add_attributes(struct uio_device *idev) } for (pi = 0; pi < MAX_UIO_PORT_REGIONS; pi++) { + ret = -ENOMEM; port = &idev->info->port[pi]; if (port->size == 0) break; -- 1.7.9 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/