Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159Ab2K3FkT (ORCPT ); Fri, 30 Nov 2012 00:40:19 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:52606 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753996Ab2K3FkR (ORCPT ); Fri, 30 Nov 2012 00:40:17 -0500 Message-ID: <50B846B2.9040700@gmail.com> Date: Fri, 30 Nov 2012 11:10:02 +0530 From: Abhijit Pawar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Al Viro CC: Abhijit Pawar , linux-fsdevel@vger.kernel.org, "linux-btrfs@vger.kernel.org" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization References: <508924AB.4060902@gmail.com> <20121026131441.GA22256@andromeda.usersys.redhat.com> <20121130040556.GD4939@ZenIV.linux.org.uk> In-Reply-To: <20121130040556.GD4939@ZenIV.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 32 On 11/30/2012 09:35 AM, Al Viro wrote: > On Fri, Oct 26, 2012 at 11:14:41AM -0200, Carlos Maiolino wrote: >> Hi, >> >> On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: >>> Hi, >>> set_anon_super is called by many filesystems. Some call directly and >>> some call through the wrapper. Many of them in the wrapper's call to >>> this function are passing the second argument to this function which >>> is not used anywhere. >>> >>> This patch replaces the second variable with NULL. >>> >> >> If the variable isn't used anymore, why don't just get rid of it, instead of >> call the function passing a NULL pointer on it? > > Because we want it to be a valid sget() callback. I doubt that this > optimization is worth doing, though - might even micro-pessimize the things > on architectures where all arguments are passed in registers. > Al, Yes. it will be helpful in registers case. -- - Abhijit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/