Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755434Ab2K3GPB (ORCPT ); Fri, 30 Nov 2012 01:15:01 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:46759 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753059Ab2K3GO7 (ORCPT ); Fri, 30 Nov 2012 01:14:59 -0500 MIME-Version: 1.0 X-Originating-IP: [173.13.129.225] In-Reply-To: References: <1354165536-18529-1-git-send-email-ch.naveen@samsung.com> <1354165536-18529-3-git-send-email-ch.naveen@samsung.com> <20121129163448.GA3761@sirena.org.uk> Date: Thu, 29 Nov 2012 22:14:58 -0800 Message-ID: Subject: Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation From: Olof Johansson To: Simon Glass Cc: Mark Brown , Naveen Krishna Chatradhi , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, grundler@chromium.org, naveen@chromium.org, w.sang@pengutronix.de, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 32 On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > +Olof > > On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown > wrote: >> On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: >> >>> The arbitrator is a general purpose function which uses two GPIOs to >>> communicate with another device to claim/release a bus. We use it to >>> arbitrate an i2c port between the AP and the EC. >> >> Should this not be layerd on top of the I2C controller rather than part >> of the controller driver? It doesn't seem terribly controller specific. > > It was originally done separately but I think it was felt that this > was overly complex. Olof can you please comment on this? it is indeed not controller specific per se, but we are unaware of any other platform/driver using it. So, it seemed reasonable to implement it in the driver as long as we have only one user; if another one comes along it's of course better to move it to the common i2c code. At least that was my opinion at the time. I could be convinced otherwise if someone else has strong opinions on the matter. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/