Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031704Ab2K3UoM (ORCPT ); Fri, 30 Nov 2012 15:44:12 -0500 Received: from mail-da0-f46.google.com ([209.85.210.46]:38493 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030302Ab2K3UoJ (ORCPT ); Fri, 30 Nov 2012 15:44:09 -0500 Date: Fri, 30 Nov 2012 12:44:06 -0800 From: Greg KH To: Dmitry Torokhov Cc: pv-drivers@vmware.com, Andy King , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [Pv-drivers] [PATCH 12/12] VMCI: Some header and config files. Message-ID: <20121130204406.GB32321@kroah.com> References: <20121127002357.GA27683@core.coreip.homeip.net> <27667508.9ZL27Yq4ZC@dtor-d630.eng.vmware.com> <20121130185755.GA26841@kroah.com> <20121130200940.GA12740@dtor-ws.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121130200940.GA12740@dtor-ws.eng.vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 30 On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote: > On Friday, November 30, 2012 10:57:55 AM Greg KH wrote: > > On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote: > > > However you snipped the rest of my reply: do we really need to renumber > > > ioctls? There is no benefit for the driver as its ioctl handler does > > > not parse the numbers into components. > > > > I don't know if you need to renumber, I really don't understand what you > > were trying to do with this code, and as it was acting differently from > > all other kernel ioctl declarations, I asked for some clarity. > > > > If you can rewrite it to look sane, and keep the same numbers, that's > > fine with me. > > OK, it looks like we can redo them as: > > #define IOCTL_VMCI_VERSION _IO(7, 0x9f) /* 1951 */ > #define IOCTL_VMCI_INIT_CONTEXT _IO(7, 0xa0) /* 1952 */ > > Is this acceptable? Sure, that's better. You also got lucky, '7' happens to be unused right now. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/